Skip to content

Commit 131c531

Browse files
MartinKavikDavid-OConnor
authored andcommitted
chore: Updated GHA workflow (wasm-pack 0.9.0 has been released)
1 parent 6800f8f commit 131c531

File tree

1 file changed

+1
-24
lines changed

1 file changed

+1
-24
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,6 @@ jobs:
1313
matrix:
1414
os: [ubuntu-latest, macos-latest] # windows-latest is too slow at the moment
1515
steps:
16-
# remove once https://github.com/rustwasm/wasm-pack/pull/706 is included in a next wasm-pack version (> 0.8.1)
17-
- name: Get write access
18-
if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest'
19-
run: |
20-
sudo chown -R $USER /usr/local/lib/node_modules
21-
sudo chown -R $USER /usr/local/bin
22-
23-
# remove once https://github.com/rustwasm/wasm-pack/pull/706 is included in a next wasm-pack version (> 0.8.1)
24-
- name: Install chromedriver
25-
run: npm install -g chromedriver --force
26-
2716
- name: Checkout sources
2817
uses: actions/checkout@v1
2918

@@ -48,9 +37,7 @@ jobs:
4837
- name: Run tests - Windows or Ubuntu
4938
if: matrix.os == 'ubuntu-latest' || matrix.os == 'windows-latest'
5039
run: |
51-
# probably a driver problem again
52-
# (see error below, we need to wait until wasm-pack > 0.8.1 is released or driver version is updated in NPM package)
53-
# cargo make test_h chrome
40+
cargo make test_h chrome
5441
cargo make test_h firefox
5542
5643
# uncomment once fixes from https://webkit.org/blog/9609/release-notes-for-safari-technology-preview-94/
@@ -64,13 +51,3 @@ jobs:
6451
- name: Verify
6552
run: cargo make verify_for_ci
6653

67-
68-
#driver status: signal: 9
69-
#driver stdout:
70-
# Starting ChromeDriver 79.0.3945.36 (3582db32b33893869b8c1339e8f4d9ed1816f143-refs/branch-heads/3945@{#614}) on port 44449
71-
# Only local connections are allowed.
72-
# Please protect ports used by ChromeDriver and related test frameworks to prevent access by malicious code.
73-
#
74-
#Error: non-200 response code: 404
75-
# {"value":{"error":"invalid session id","message":"invalid session id","stacktrace":"#0 0x55747a956479 \u003Cunknown>\n"}}
76-

0 commit comments

Comments
 (0)