Check protoc via jar first

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>

Author: ricardozanini

impl/test/src/test/java/io/serverlessworkflow/impl/test/CustomFunctionTest.java

@@ -21,7 +21,7 @@
 
 import io.serverlessworkflow.impl.WorkflowApplication;
 import io.serverlessworkflow.impl.WorkflowException;
-import io.serverlessworkflow.impl.test.junit.DisabledIfBinaryUnavailable;
+import io.serverlessworkflow.impl.test.junit.DisabledIfPythonUnavailable;
 import java.io.IOException;
 import java.util.Map;
 import org.junit.jupiter.api.AfterAll;
@@ -59,7 +59,7 @@ void testCustomFunction() {
         .isEqualTo(404);
   }
 
-  @DisabledIfBinaryUnavailable({"python", "--version"})
+  @DisabledIfPythonUnavailable()
   @ParameterizedTest
   @ValueSource(
       strings = {

impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcBiDirectionalStreamingTest.java

@@ -23,7 +23,7 @@
 import io.serverlessworkflow.impl.WorkflowDefinition;
 import io.serverlessworkflow.impl.WorkflowModel;
 import io.serverlessworkflow.impl.test.grpc.handlers.ContributorBiDiStreamingHandler;
-import io.serverlessworkflow.impl.test.junit.DisabledIfBinaryUnavailable;
+import io.serverlessworkflow.impl.test.junit.DisabledIfProtocUnavailable;
 import java.io.IOException;
 import java.util.Collection;
 import java.util.Map;
@@ -32,7 +32,7 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-@DisabledIfBinaryUnavailable({"protoc", "--version"})
+@DisabledIfProtocUnavailable
 public class GrpcBiDirectionalStreamingTest {
 
   private static final int PORT_FOR_EXAMPLES = 5011;

impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcClientStreamingTest.java

@@ -22,7 +22,7 @@
 import io.serverlessworkflow.impl.WorkflowApplication;
 import io.serverlessworkflow.impl.WorkflowDefinition;
 import io.serverlessworkflow.impl.test.grpc.handlers.ContributorClientStreamingHandler;
-import io.serverlessworkflow.impl.test.junit.DisabledIfBinaryUnavailable;
+import io.serverlessworkflow.impl.test.junit.DisabledIfProtocUnavailable;
 import java.io.IOException;
 import java.util.List;
 import java.util.Map;
@@ -31,7 +31,7 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-@DisabledIfBinaryUnavailable({"protoc", "--version"})
+@DisabledIfProtocUnavailable
 public class GrpcClientStreamingTest {
 
   private static final int PORT_FOR_EXAMPLES = 5011;

impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcServerStreamingTest.java

@@ -23,7 +23,7 @@
 import io.serverlessworkflow.impl.WorkflowDefinition;
 import io.serverlessworkflow.impl.WorkflowModel;
 import io.serverlessworkflow.impl.test.grpc.handlers.ContributorServerStreamingHandler;
-import io.serverlessworkflow.impl.test.junit.DisabledIfBinaryUnavailable;
+import io.serverlessworkflow.impl.test.junit.DisabledIfProtocUnavailable;
 import java.io.IOException;
 import java.util.Collection;
 import java.util.Map;
@@ -32,7 +32,7 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-@DisabledIfBinaryUnavailable({"protoc", "--version"})
+@DisabledIfProtocUnavailable
 public class GrpcServerStreamingTest {
 
   private static final int PORT_FOR_EXAMPLES = 5011;

impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryArgsExprTest.java

@@ -22,15 +22,15 @@
 import io.serverlessworkflow.impl.WorkflowApplication;
 import io.serverlessworkflow.impl.WorkflowDefinition;
 import io.serverlessworkflow.impl.test.grpc.handlers.ContributorUnaryArgsExprHandler;
-import io.serverlessworkflow.impl.test.junit.DisabledIfBinaryUnavailable;
+import io.serverlessworkflow.impl.test.junit.DisabledIfProtocUnavailable;
 import java.io.IOException;
 import java.util.Map;
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-@DisabledIfBinaryUnavailable({"protoc", "--version"})
+@DisabledIfProtocUnavailable
 public class GrpcUnaryArgsExprTest {
 
   private static final int PORT_FOR_EXAMPLES = 5011;

impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryTest.java

@@ -22,15 +22,15 @@
 import io.serverlessworkflow.impl.WorkflowApplication;
 import io.serverlessworkflow.impl.WorkflowDefinition;
 import io.serverlessworkflow.impl.test.grpc.handlers.PersonUnaryHandler;
-import io.serverlessworkflow.impl.test.junit.DisabledIfBinaryUnavailable;
+import io.serverlessworkflow.impl.test.junit.DisabledIfProtocUnavailable;
 import java.io.IOException;
 import java.util.Map;
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-@DisabledIfBinaryUnavailable({"protoc", "--version"})
+@DisabledIfProtocUnavailable
 public class GrpcUnaryTest {
 
   private static final int PORT_FOR_EXAMPLES = 5011;

impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckUtil.java

@@ -0,0 +1,53 @@
+/*
+ * Copyright 2020-Present The Serverless Workflow Specification Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.serverlessworkflow.impl.test.junit;
+
+import java.io.IOException;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+
+public final class BinaryCheckUtil {
+
+  private BinaryCheckUtil() {}
+
+  private static final ConcurrentMap<String, Boolean> BINARY_CHECKS = new ConcurrentHashMap<>();
+
+  public static boolean isBinaryAvailable(String... command) {
+    return BINARY_CHECKS.computeIfAbsent(
+        String.join(" ", command),
+        __ -> {
+          try {
+            Process process =
+                new ProcessBuilder(command)
+                    .redirectErrorStream(true)
+                    .redirectOutput(ProcessBuilder.Redirect.DISCARD)
+                    .start();
+            boolean finished = process.waitFor(2, TimeUnit.SECONDS);
+            if (finished) {
+              return process.exitValue() == 0;
+            }
+            process.destroyForcibly();
+            return false;
+          } catch (IOException | InterruptedException e) {
+            if (e instanceof InterruptedException) {
+              Thread.currentThread().interrupt();
+            }
+            return false;
+          }
+        });
+  }
+}

…t/junit/DisabledIfBinaryUnavailable.java …t/junit/DisabledIfProtocUnavailable.javaimpl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfBinaryUnavailable.java renamed to impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfProtocUnavailable.java impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfBinaryUnavailable.java renamed to impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfProtocUnavailable.java

@@ -23,7 +23,5 @@
 
 @Target({ElementType.TYPE, ElementType.METHOD})
 @Retention(RetentionPolicy.RUNTIME)
-@ExtendWith(BinaryCheckCondition.class)
-public @interface DisabledIfBinaryUnavailable {
-  String[] value();
-}
+@ExtendWith(ProtocCheckCondition.class)
+public @interface DisabledIfProtocUnavailable {}

impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfPythonUnavailable.java

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2020-Present The Serverless Workflow Specification Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.serverlessworkflow.impl.test.junit;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+@Target({ElementType.TYPE, ElementType.METHOD})
+@Retention(RetentionPolicy.RUNTIME)
+@ExtendWith(PythonCheckCondition.class)
+public @interface DisabledIfPythonUnavailable {}

…mpl/test/junit/BinaryCheckCondition.java …mpl/test/junit/ProtocCheckCondition.javaimpl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java renamed to impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/ProtocCheckCondition.java impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java renamed to impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/ProtocCheckCondition.java

@@ -15,53 +15,52 @@
  */
 package io.serverlessworkflow.impl.test.junit;
 
-import java.io.IOException;
-import java.util.concurrent.TimeUnit;
+import static io.serverlessworkflow.impl.test.junit.BinaryCheckUtil.isBinaryAvailable;
+
+import com.github.os72.protocjar.Protoc;
+import java.util.concurrent.atomic.AtomicReference;
 import org.junit.jupiter.api.extension.ConditionEvaluationResult;
 import org.junit.jupiter.api.extension.ExecutionCondition;
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.platform.commons.util.AnnotationUtils;
 
-public class BinaryCheckCondition implements ExecutionCondition {
+public class ProtocCheckCondition implements ExecutionCondition {
+
+  private static final AtomicReference<Boolean> protocAvailable = new AtomicReference<>(null);
 
   @Override
   public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext context) {
-    return AnnotationUtils.findAnnotation(context.getElement(), DisabledIfBinaryUnavailable.class)
+    return AnnotationUtils.findAnnotation(context.getElement(), DisabledIfProtocUnavailable.class)
         .map(
             annotation -> {
-              String[] binary = annotation.value();
-              if (binary == null || binary.length == 0) {
+              if (isProtocAvailable()) {
                 return ConditionEvaluationResult.enabled(
-                    "No command found in the annotation @DisabledIfBinaryUnavailable");
-              }
-              if (isBinaryAvailable(binary)) {
-                return ConditionEvaluationResult.enabled(binary[0] + " is available.");
+                    "Protoc is available for the current platform.");
               } else {
                 return ConditionEvaluationResult.disabled(
-                    "Test disabled: " + binary[0] + " not found.");
+                    "Test disabled: Protoc not currently available not found.");
               }
             })
-        .orElse(ConditionEvaluationResult.enabled("No @DisabledIfBinaryUnavailable found."));
+        .orElse(ConditionEvaluationResult.enabled("No @DisabledIfProtocUnavailable found."));
   }
 
-  public boolean isBinaryAvailable(String... command) {
+  private boolean isProtocAvailable() {
+    Boolean cached = protocAvailable.get();
+    if (cached != null) {
+      return cached;
+    }
+
+    boolean found = false;
     try {
-      Process process =
-          new ProcessBuilder(command)
-              .redirectErrorStream(true)
-              .redirectOutput(ProcessBuilder.Redirect.DISCARD)
-              .start();
-      boolean finished = process.waitFor(2, TimeUnit.SECONDS);
-      if (finished) {
-        return process.exitValue() == 0;
-      }
-      process.destroyForcibly();
-      return false;
-    } catch (IOException | InterruptedException e) {
-      if (e instanceof InterruptedException) {
-        Thread.currentThread().interrupt();
-      }
-      return false;
+      if (Protoc.runProtoc(new String[] {"--version"}) == 0) found = true;
+    } catch (Exception e) {
+      // ignore
     }
+
+    if (!found) found = isBinaryAvailable("protoc", "--version");
+
+    protocAvailable.compareAndSet(null, found);
+
+    return protocAvailable.get();
   }
 }