[Fix #1198] Copilot comments

Signed-off-by: fjtirado <ftirados@redhat.com>
Update impl/test/src/test/resources/workflows-samples/try-catch-not-match-details.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update impl/test/src/test/resources/workflows-samples/try-catch-match-status.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update impl/test/src/test/resources/workflows-samples/try-catch-match-details.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: fjtirado

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java

@@ -171,11 +171,16 @@ private CompletableFuture<WorkflowModel> handleException(
       WorkflowException exception = (WorkflowException) e;
       CompletableFuture<WorkflowModel> completable =
           CompletableFuture.completedFuture(taskContext.rawOutput());
-      if (errorFilter.map(f -> f.test(exception.getWorkflowError())).orElse(true)
+      WorkflowError error = exception.getWorkflowError();
+      if (errorFilter.map(f -> f.test(error)).orElse(true)
           && WorkflowUtils.whenExceptTest(
-              whenFilter, exceptFilter, workflow, taskContext, taskContext.rawOutput())) {
+              whenFilter,
+              exceptFilter,
+              workflow,
+              taskContext,
+              workflow.definition().application().modelFactory().fromAny(error))) {
         if (errorVariable != null) {
-          taskContext.variables().put(errorVariable, exception.getWorkflowError());
+          taskContext.variables().put(errorVariable, error);
         }
         if (catchTaskExecutor.isPresent()) {
           completable =

impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java

@@ -125,7 +125,27 @@ void testTimeout() throws IOException {
   @ParameterizedTest
   @ValueSource(
       strings = {
-        "workflows-samples/try-catch-not-match.yaml",
+        "workflows-samples/try-catch-match-when.yaml",
+        "workflows-samples/try-catch-match-status.yaml",
+        "workflows-samples/try-catch-match-details.yaml"
+      })
+  void testDoesMatch(String path) throws IOException {
+    assertThat(
+            app.workflowDefinition(readWorkflowFromClasspath(path))
+                .instance(Map.of())
+                .start()
+                .join()
+                .asMap()
+                .map(m -> m.get("recovered"))
+                .orElseThrow())
+        .isEqualTo(true);
+  }
+
+  @ParameterizedTest
+  @ValueSource(
+      strings = {
+        "workflows-samples/try-catch-not-match-when.yaml",
+        "workflows-samples/try-catch-not-match-status.yaml",
         "workflows-samples/try-catch-not-match-details.yaml"
       })
   void testDoesNotMatch(String path) {

impl/test/src/test/resources/workflows-samples/try-catch-match-details.yaml

@@ -0,0 +1,24 @@
+document:
+  dsl: '1.0.0'
+  namespace: test
+  name: try-catch-match-details
+  version: '0.1.0'
+do:
+  - attemptTask:
+      try:
+        - failingTask:
+            raise:
+              error:
+                type: https://example.com/errors/transient
+                status: 503
+                detail: Enforcement Failure - invalid email
+      catch:
+        errors:
+          with:
+            type: https://example.com/errors/transient
+            status: 503
+            details: Enforcement Failure - invalid email
+        do:
+          - handleError:
+              set:
+                recovered: true

impl/test/src/test/resources/workflows-samples/try-catch-match-status.yaml

@@ -0,0 +1,22 @@
+document:
+  dsl: '1.0.0'
+  namespace: test
+  name: try-catch-match-status
+  version: '0.1.0'
+do:
+  - attemptTask:
+      try:
+        - failingTask:
+            raise:
+              error:
+                type: https://example.com/errors/transient
+                status: 503
+      catch:
+        errors:
+          with:
+            type: https://example.com/errors/transient
+            status: 503
+        do:
+          - handleError:
+              set:
+                recovered: true

impl/test/src/test/resources/workflows-samples/try-catch-match-when.yaml

@@ -0,0 +1,19 @@
+document:
+  dsl: '1.0.0'
+  namespace: test
+  name: try-catch-match-when
+  version: '0.1.0'
+do:
+  - attemptTask:
+      try:
+          - failingTask:
+                  raise:
+                      error:
+                          type: https://example.com/errors/transient
+                          status: 503
+      catch:
+          when: ${ .status == 503 }
+          do:
+              - handleError:
+                      set:
+                          recovered: true

impl/test/src/test/resources/workflows-samples/try-catch-not-match-details.yaml

@@ -17,5 +17,4 @@ do:
                 with:
                     type: https://example.com/errors/security
                     status: 403
-                    details: User not found in tenant catalog
- 
+                    details: User not found in tenant catalog

impl/test/src/test/resources/workflows-samples/try-catch-not-match-status.yaml

@@ -0,0 +1,18 @@
+document:
+  dsl: '1.0.0'
+  namespace: test
+  name: try-catch-not-match-status
+  version: '0.1.0'
+do:
+  - attemptTask:
+      try:
+          - failingTask:
+                  raise:
+                      error:
+                          type: https://example.com/errors/transient
+                          status: 503
+      catch:
+        errors:
+            with:
+               type: https://example.com/errors/transient
+               status: 403

…rkflows-samples/try-catch-not-match.yaml …ws-samples/try-catch-not-match-when.yamlimpl/test/src/test/resources/workflows-samples/try-catch-not-match.yaml renamed to impl/test/src/test/resources/workflows-samples/try-catch-not-match-when.yaml impl/test/src/test/resources/workflows-samples/try-catch-not-match.yaml renamed to impl/test/src/test/resources/workflows-samples/try-catch-not-match-when.yaml

@@ -1,7 +1,7 @@
 document:
   dsl: '1.0.0'
   namespace: test
-  name: try-catch-not-match
+  name: try-catch-not-match-when
   version: '0.1.0'
 do:
   - attemptTask: