Merge pull request #547 from serverlessworkflow/fix-workflow-instance-status-update

cdavernas · web-flow · commit 4f4a31476cfd · 2025-08-25T12:27:02.000+02:00
Fixed the `WorkflowInstanceHandler` n,ot to use otpimistic concurrency when updating workflow instance status
diff --git a/src/operator/Synapse.Operator/Services/WorkflowInstanceHandler.cs b/src/operator/Synapse.Operator/Services/WorkflowInstanceHandler.cs
@@ -229,7 +229,7 @@ protected virtual async Task UpdateWorkflowInstanceStatusAsync(Action<WorkflowIn
                 updated.Status ??= new();
                 statusUpdate(updated.Status);
                 var patch = JsonPatchUtility.CreateJsonPatchFromDiff(original, updated);
-                await this.Resources.PatchStatusAsync<WorkflowInstance>(new Patch(PatchType.JsonPatch, patch), updated.GetName(), updated.GetNamespace(), original.Metadata.ResourceVersion, false, cancellationToken).ConfigureAwait(false);
+                await this.Resources.PatchStatusAsync<WorkflowInstance>(new Patch(PatchType.JsonPatch, patch), updated.GetName(), updated.GetNamespace(), null, false, cancellationToken).ConfigureAwait(false);
             }
             catch (ConcurrencyException) when (attempt + 1 < maxRetries)
             {

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ protected virtual async Task UpdateWorkflowInstanceStatusAsync(Action<WorkflowIn`
`229`	`229`	`updated.Status ??= new();`
`230`	`230`	`statusUpdate(updated.Status);`
`231`	`231`	`var patch = JsonPatchUtility.CreateJsonPatchFromDiff(original, updated);`
`232`		`- await this.Resources.PatchStatusAsync<WorkflowInstance>(new Patch(PatchType.JsonPatch, patch), updated.GetName(), updated.GetNamespace(), original.Metadata.ResourceVersion, false, cancellationToken).ConfigureAwait(false);`
	`232`	`+ await this.Resources.PatchStatusAsync<WorkflowInstance>(new Patch(PatchType.JsonPatch, patch), updated.GetName(), updated.GetNamespace(), null, false, cancellationToken).ConfigureAwait(false);`
`233`	`233`	`}`
`234`	`234`	`catch (ConcurrencyException) when (attempt + 1 < maxRetries)`
`235`	`235`	`{`