Optimize TranslatorContext (#261)

* Optimize `TranslatorContext`

* ArgumentNullException.ThrowIfNull()

* Fix AliasGenerators

* in arg

* in arg

* Optimize `CompositePostCompiler`

* Optimize ColumnIndexMapping

* Optimize NodeCollection

* Optimize BuildKeyInfo()

Author: SergeiPavlov

Orm/Xtensive.Orm.Firebird/Orm.Providers.Firebird/SqlCompiler.cs

@@ -8,13 +8,6 @@
 
 namespace Xtensive.Orm.Providers.Firebird
 {
-  internal class SqlCompiler : Providers.SqlCompiler
-  {
-    // Constructors
-
-    public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
-      : base(handlers, configuration)
-    {
-    }
-  }
-}
+  internal class SqlCompiler(HandlerAccessor handlers, in CompilerConfiguration configuration)
+    : Providers.SqlCompiler(handlers, configuration);
+}

Orm/Xtensive.Orm.MySql/Orm.Providers.MySql/SqlCompiler.cs

@@ -9,13 +9,6 @@
 
 namespace Xtensive.Orm.Providers.MySql
 {
-  internal class SqlCompiler : Providers.SqlCompiler
-  {
-    // Constructors
-    
-    public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
-      : base(handlers, configuration)
-    {
-    }
-  }
-}
+  internal class SqlCompiler(HandlerAccessor handlers, in CompilerConfiguration configuration)
+    : Providers.SqlCompiler(handlers, configuration);
+}

Orm/Xtensive.Orm.Oracle/Orm.Providers.Oracle/SqlCompiler.cs

@@ -37,9 +37,9 @@ protected override SqlExpression ProcessAggregate(SqlProvider source, IReadOnlyL
 
     // Constructors
 
-    public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
+    public SqlCompiler(HandlerAccessor handlers, in CompilerConfiguration configuration)
       : base(handlers, configuration)
     {
     }
   }
-}
+}

Orm/Xtensive.Orm.PostgreSql/Orm.Providers.PostgreSql/DomainHandler.cs

@@ -35,4 +35,4 @@ protected override IEnumerable<Type> GetProviderCompilerContainers()
         });
     }
   }
-}
+}

Orm/Xtensive.Orm.PostgreSql/Orm.Providers.PostgreSql/SqlCompiler.cs

@@ -62,7 +62,7 @@ protected override SqlExpression ProcessAggregate(SqlProvider source, IReadOnlyL
       return result;
     }
 
-    public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
+    public SqlCompiler(HandlerAccessor handlers, in CompilerConfiguration configuration)
       : base(handlers, configuration)
     {
     }

Orm/Xtensive.Orm.SqlServer/Orm.Providers.SqlServer/DomainHandler.cs

@@ -17,10 +17,7 @@ namespace Xtensive.Orm.Providers.SqlServer
   public class DomainHandler : Providers.DomainHandler
   {
     /// <inheritdoc/>
-    protected override ICompiler CreateCompiler(CompilerConfiguration configuration)
-    {
-      return new SqlCompiler(Handlers, configuration);
-    }
+    protected override ICompiler CreateCompiler(CompilerConfiguration configuration) => new SqlCompiler(Handlers, configuration);
 
     /// <inheritdoc/>
     protected override SearchConditionCompiler CreateSearchConditionVisitor()
@@ -30,4 +27,4 @@ protected override SearchConditionCompiler CreateSearchConditionVisitor()
       return new SearchConditionCompilerV11();
     }
   }
-}
+}

Orm/Xtensive.Orm.SqlServer/Orm.Providers.SqlServer/SqlCompiler.cs

@@ -15,7 +15,7 @@
 
 namespace Xtensive.Orm.Providers.SqlServer
 {
-  internal class SqlCompiler : Providers.SqlCompiler
+  internal class SqlCompiler(HandlerAccessor handlers, in CompilerConfiguration configuration) : Providers.SqlCompiler(handlers, configuration)
   {
     private static readonly Type ByteType = typeof(byte);
     private static readonly Type Int16Type = typeof(short);
@@ -149,12 +149,5 @@ private bool ShouldCastDueType(Type type)
         || type == DecimalType
         || type == FloatType;
     }
-
-    // Constructors
-
-    public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
-      : base(handlers, configuration)
-    {
-    }
   }
 }

Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/v09/ColumnResolver.cs

@@ -4,59 +4,35 @@
 // Created by: Dmitri Maximov
 // Created:    2009.08.12
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Xtensive.Sql.Model;
 
 namespace Xtensive.Sql.Drivers.SqlServer.v09
 {
-  internal sealed class ColumnResolver
+  internal sealed class ColumnResolver(DataTable table)
   {
-    public DataTable Table;
-    private List<ColumnIndexMapping> columnMappings;
-
-    private class ColumnIndexMapping
-    {
-      public readonly int DbIndex;
-      public readonly int ModelIndex;
-
-      public ColumnIndexMapping(int dbIndex, int modelIndex)
-      {
-        DbIndex = dbIndex;
-        ModelIndex = modelIndex;
-      }
-    }
+    private readonly record struct ColumnIndexMapping(int DbIndex, int ModelIndex, bool IsValid);
 
-    public void RegisterColumnMapping(int dbIndex, int modelIndex)
-    {
-      if (columnMappings == null)
-        columnMappings = new List<ColumnIndexMapping>(1);
+    public DataTable Table = table;
+    private List<ColumnIndexMapping> columnMappings;
 
-      columnMappings.Add(new ColumnIndexMapping(dbIndex, modelIndex));
-    }
+    public void RegisterColumnMapping(int dbIndex, int modelIndex) =>
+      (columnMappings ??= new(1)).Add(new ColumnIndexMapping(dbIndex, modelIndex, true));
 
     public DataTableColumn GetColumn(int dbIndex)
     {
       int modelIndex = dbIndex-1;
-      var view = Table as View;
-      if (view != null)
+      if (Table is View view)
         return view.ViewColumns[modelIndex];
 
       var table = (Table)Table;
       if (columnMappings == null)
         return table.TableColumns[modelIndex];
 
-      var mapping = columnMappings.Where(item => item.DbIndex==dbIndex).FirstOrDefault();
-      if (mapping != null)
+      var mapping = columnMappings.FirstOrDefault(item => item.DbIndex==dbIndex);
+      if (mapping != default)
         return table.TableColumns[mapping.ModelIndex];
 
       throw new ArgumentOutOfRangeException("dbIndex");
     }
-
-    public ColumnResolver(DataTable table)
-    {
-      Table = table;
-    }
   }
-}
+}

Orm/Xtensive.Orm.Sqlite/Orm.Providers.Sqlite/SqlCompiler.cs

@@ -8,14 +8,6 @@
 
 namespace Xtensive.Orm.Providers.Sqlite
 {
-  internal class SqlCompiler : Providers.SqlCompiler
-  {
-
-    // Constructors
-    
-    public SqlCompiler(HandlerAccessor handlers, CompilerConfiguration configuration)
-      : base(handlers, configuration)
-    {
-    }
-  }
-}
+  internal class SqlCompiler(HandlerAccessor handlers, in CompilerConfiguration configuration)
+    : Providers.SqlCompiler(handlers, configuration);
+}

Orm/Xtensive.Orm/Core/AliasGenerator.cs

@@ -12,7 +12,7 @@ namespace Xtensive.Core
   /// Universal alias generator.
   /// </summary>
   [Serializable]
-  public sealed class AliasGenerator
+  public struct AliasGenerator
   {
     /// <summary>
     /// Default alias template. Value is "{0}{1}". Where {0} - template parameter for prefix and {1} - template parameter for suffix.
@@ -93,7 +93,7 @@ public static AliasGenerator Create(string[] overriddenPrefixes, string aliasTem
 
     // Constructors
 
-    private AliasGenerator()
+    public AliasGenerator()
       : this (DefaultAliasTemplate)
     {}
 
@@ -111,4 +111,4 @@ private AliasGenerator(string[] prefixes, string aliasTemplate)
       this.aliasTemplate = aliasTemplate;
     }
   }
-}
+}