You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: community/index.md
+4Lines changed: 4 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -42,6 +42,10 @@ Pull requests are expected to be reviewed by the committers within 24 hours afte
42
42
43
43
Changes that add or modify syntax, language features, Slang's core module, or the compilation and reflection API must go through our process for language changes. The full process is [documented here](/community/language-change-process).
44
44
45
+
#### Updates for the Processes
46
+
47
+
The above processes can be updated to meet the changing needs of the Slang project. Updates to these processes can be made via pull request to the [Slang website repository](https://github.com/shader-slang/shader-slang.github.io) after community discussion and with PR approval by at least two Language Owners.
48
+
45
49
## Submitting a Pull Request
46
50
47
51
If you are ready to start contributing, please follow our [guide for creating a pull request](https://github.com/shader-slang/slang/blob/master/CONTRIBUTION.md). All pull requests are expected to meet our [bar of code quality](/community/code-quality).
Copy file name to clipboardExpand all lines: community/language-change-process.md
+6-4Lines changed: 6 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,7 @@
2
2
3
3
Changes that touch Slang's language and user-facing interfaces, including syntax, core module and public APIs need to follow the feature change process described in this document.
4
4
5
-
Before undertaking the rest of the process, you are encouraged to “pitch” your idea on the Slang GitHub forum, in order to solicit informal feedback from the community. Feedback at this stage can help refine an idea, suggest directions, and identify potential collaborators.
5
+
Before undertaking the rest of the process, you are encouraged to "pitch" your idea on the Slang GitHub forum, in order to solicit informal feedback from the community. Feedback at this stage can help refine an idea, suggest directions, and identify potential collaborators.
6
6
7
7
## File a Feature Tracker
8
8
The first step of doing a feature change is to file a "Feature Tracker" issue on our github with associated FeatureTracker label to begin including all template fields included. You will need to be a committer, or ask a committer or community member with greater access to the repo to do this, see [community structure](/community/index#community-structure) for how to do so.
@@ -21,10 +21,11 @@ Announce your intent to implement the feature in the [Announcement Channel in Gi
21
21
22
22
The Owners of docs/proposals (aka the "Language Owners") may weigh in on feature proposal issues to give guidance on what they expect will or will not be accepted as changes to the language.
23
23
24
-
If it is clear to the language Owners that a proposed feature will not be accepted, they may close out the issue with an explanation of the reasoning.
25
-
Ideally, you should wait to get positive feedback from at least one language OWNER before moving forward with implementation, to avoid the possibility of wasted effort.
24
+
If it is clear to the Language Owners that a proposed feature will not be accepted, they may close out the issue with an explanation of the reasoning.
25
+
Ideally, you should wait to get positive feedback from at least one Language Owner before moving forward with implementation, to avoid the possibility of wasted effort.
26
+
The Language Owners are responsible for making a decision on whether or not to proceed with implementation for all proposals to remove the ambiguity in the case of insufficient or mixed community feedback.
26
27
27
-
Assuming positive community support for your proposal, move your tracking issue's status to "experimental" and begin putting up PRs for reviews by relevant code Owners.
28
+
With positive support for your proposal from the Language Owners, move your tracking issue's status to "experimental" and begin putting up PRs for reviews by relevant code Owners.
28
29
29
30
During the implementation period, you are expected to:
30
31
@@ -47,3 +48,4 @@ At decision time, the Owners listed in `.github/CODEOWNERS` will discuss private
47
48
We expect that between 3-7 days will be given for community feedback in typical cases. Some lived experience is needed before we can make a policy about how long review periods need to last.
48
49
49
50
The total time spent from creation of the tracking issue to when a feature is marked "stable" may vary with the complexity of a feature, but we expect that it will typically fall in the 1-3 month range. Even if a small feature might be proposed and implemented in a matter of days, it would need to be given sufficient time in the experimental state for community engagement and feedback before being considered for stabilization.
0 commit comments