Validate -render-features in render-test (#8940)

# Main Changes

Add validation for `-render-feature` and `-render-features` flags
against `SLANG_RHI_FEATURES`. Invalid feature names now fail immediately
during option parsing with clear error messages.

**Implementation:**

* Add `isValidFeatureName()` helper function using `SLANG_RHI_FEATURES`
macro
* Add workaround (WAR) to accept `cooperative-matrix-*` patterns until
RHI backend supports them
* Emit warning when WAR is triggered
* Add diagnostic error 1006 for invalid render features

Fixes #8274

# Test Fixes

**Fixed capability misuse:**

* Changed `cuda_sm_7_0` from `-render-feature` to `-capability` in wave
operation tests (5 files)

# Cooperative-Matrix WAR

Tests use cooperative-matrix-2 sub-features (e.g.,
`cooperative-matrix-reductions`, `cooperative-matrix-tensor-addressing`)
not yet in `SLANG_RHI_FEATURES`.

**Solution:** WAR accepts `cooperative-matrix-*` patterns, allowing:

* Tests remain enabled and skip gracefully on unsupported hardware
* No CI failures (Tesla T4 lacks cooperative-matrix-2)
* Auto-enable when RHI backend implements `VK_NV_cooperative_matrix2`

# Code Cleanup

* Fixed include order and removed unused includes from `options.cpp`

# Testing

* Invalid features caught with clear errors
* Cooperative-matrix tests skip gracefully on unsupported hardware

Author: jvepsalainen-nv

tests/hlsl-intrinsic/active-mask/switch-trivial-fallthrough.slang

@@ -22,7 +22,7 @@
 // target because we do not synthesize the active
 // mask value we want/expect to see.
 //
-//DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-cuda -compute -render-features cuda_sm_7_0
+//DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-cuda -compute -capability cuda_sm_7_0
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0], stride=4):out,name buffer
 RWStructuredBuffer<int> buffer;

tests/hlsl-intrinsic/active-mask/switch.slang

@@ -6,7 +6,7 @@
 //DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj
 //DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -dx12 -profile cs_6_0 -xslang -DHACK -shaderobj
 //TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -xslang -DHACK -shaderobj
-//TEST(compute):COMPARE_COMPUTE_EX:-cuda -compute -render-features cuda_sm_7_0
+//TEST(compute):COMPARE_COMPUTE_EX:-cuda -compute -capability cuda_sm_7_0
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0], stride=4):out,name buffer
 RWStructuredBuffer<int> buffer;

tests/hlsl-intrinsic/wave-active-count-bits.slang

@@ -4,7 +4,7 @@
 //TEST:COMPARE_COMPUTE_EX:-slang -compute -dx12 -profile cs_6_0 -shaderobj -render-feature hardware-device
 //TEST:COMPARE_COMPUTE_EX:-slang -compute -cuda -profile cs_6_0 -shaderobj -render-feature hardware-device
 //TEST(vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -render-feature hardware-device
-//TEST:COMPARE_COMPUTE_EX:-cuda -compute -render-features cuda_sm_7_0 -shaderobj
+//TEST:COMPARE_COMPUTE_EX:-cuda -compute -capability cuda_sm_7_0 -shaderobj
 //TEST:COMPARE_COMPUTE_EX:-metal -compute -shaderobj
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0 0 0 0 0], stride=4):out,name outputBuffer

tests/hlsl-intrinsic/wave-broadcast-lane-at.slang

@@ -4,7 +4,7 @@
 TEST:COMPARE_COMPUTE_EX:-slang -compute -dx12 -profile cs_6_0 -shaderobj
 // Disabled on VK because glsl can't do WaveReadLaneAt on matrix. 
 //DISABLE_TEST(vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj
-TEST:COMPARE_COMPUTE_EX:-cuda -compute -render-features cuda_sm_7_0 -shaderobj
+TEST:COMPARE_COMPUTE_EX:-cuda -compute -capability cuda_sm_7_0 -shaderobj
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name outputBuffer
 RWStructuredBuffer<int> outputBuffer;

tests/hlsl-intrinsic/wave-shuffle.slang

@@ -5,7 +5,7 @@
 //DISABLE_TEST:COMPARE_COMPUTE_EX:-slang -compute -dx12 -profile cs_6_0
 // Disabled because vk doesn't currently support matrix types. See wave-shuffle-vk.slang
 //DISABLE_TEST(vulkan):COMPARE_COMPUTE_EX:-vk -compute
-TEST:COMPARE_COMPUTE_EX:-cuda -compute -render-features cuda_sm_7_0
+TEST:COMPARE_COMPUTE_EX:-cuda -compute -capability cuda_sm_7_0
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name outputBuffer
 RWStructuredBuffer<int> outputBuffer;

tools/render-test/diagnostic-defs.h

@@ -37,5 +37,6 @@ DIAGNOSTIC(1003, Error, unknownSourceLanguage, "unknown source language name")
 DIAGNOSTIC(1003, Error, unknown, "unknown source language name")
 DIAGNOSTIC(1004, Error, unknownCommandLineOption, "unknown command-line option '$0'")
 DIAGNOSTIC(1005, Error, unexpectedPositionalArg, "unexpected positional arg")
+DIAGNOSTIC(1006, Error, invalidRenderFeature, "invalid render feature name '$0'")
 
 #undef DIAGNOSTIC

tools/render-test/options.cpp

@@ -2,24 +2,58 @@
 
 #include "options.h"
 
+#include "../../source/compiler-core/slang-command-line-args.h"
 #include "../../source/core/slang-list.h"
 #include "../../source/core/slang-render-api-util.h"
 #include "../../source/core/slang-string-util.h"
+#include "../../source/core/slang-type-text-util.h"
 #include "../../source/core/slang-writer.h"
+#include "diagnostics.h"
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
-// #include "../../source/core/slang-downstream-compiler.h"
-
-#include "../../source/compiler-core/slang-command-line-args.h"
-#include "../../source/core/slang-type-text-util.h"
-#include "diagnostics.h"
 
 namespace renderer_test
 {
 using namespace Slang;
 
+// Helper function to check if a feature name is valid
+static bool isValidFeatureName(
+    const UnownedStringSlice& featureName,
+    DiagnosticSink* sink,
+    SourceLoc loc)
+{
+    // WAR: Accept cooperative-matrix-2 sub-features until RHI backend supports them
+    // These features will be gracefully skipped at runtime if hardware doesn't support them
+    if (featureName.startsWith("cooperative-matrix-"))
+    {
+        if (sink)
+        {
+            sink->diagnoseRaw(
+                Severity::Warning,
+                "Using cooperative-matrix-2 feature that is not yet fully supported "
+                "in RHI backend. "
+                "Test will be skipped if hardware doesn't support it.");
+        }
+        return true;
+    }
+
+#define SLANG_RHI_FEATURES_X(id, name) name,
+    static const char* kValidFeatureNames[] = {SLANG_RHI_FEATURES(SLANG_RHI_FEATURES_X)};
+#undef SLANG_RHI_FEATURES_X
+
+    static const int kFeatureCount = sizeof(kValidFeatureNames) / sizeof(kValidFeatureNames[0]);
+
+    for (int i = 0; i < kFeatureCount; i++)
+    {
+        if (featureName == UnownedStringSlice(kValidFeatureNames[i]))
+        {
+            return true;
+        }
+    }
+    return false;
+}
+
 static rhi::DeviceType _toRenderType(Slang::RenderApiType apiType)
 {
     using namespace Slang;
@@ -111,14 +145,23 @@ static rhi::DeviceType _toRenderType(Slang::RenderApiType apiType)
         }
         else if (argValue == "-render-features" || argValue == "-render-feature")
         {
-            String features;
-            SLANG_RETURN_ON_FAIL(reader.expectArg(features));
+            CommandLineArg featuresArg;
+            SLANG_RETURN_ON_FAIL(reader.expectArg(featuresArg));
 
             List<UnownedStringSlice> values;
-            StringUtil::split(features.getUnownedSlice(), ',', values);
+            StringUtil::split(featuresArg.value.getUnownedSlice(), ',', values);
 
             for (const auto& value : values)
             {
+                // Validate that the feature name is recognized
+                if (!isValidFeatureName(value, &sink, featuresArg.loc))
+                {
+                    sink.diagnose(
+                        featuresArg.loc,
+                        RenderTestDiagnostics::invalidRenderFeature,
+                        value);
+                    return SLANG_FAIL;
+                }
                 outOptions.renderFeatures.add(value);
             }
         }