Skip to content

Commit 930d61e

Browse files
committed
verify description and rule_number in unit test
1 parent 967a37d commit 930d61e

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

cloudstack/resource_cloudstack_network_acl_rule_test.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ func TestAccCloudStackNetworkACLRule_update(t *testing.T) {
8585
testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"),
8686
resource.TestCheckResourceAttr(
8787
"cloudstack_network_acl_rule.foo", "rule.#", "3"),
88+
resource.TestCheckResourceAttr(
89+
"cloudstack_network_acl_rule.foo", "rule.0.number", "10"),
8890
resource.TestCheckResourceAttr(
8991
"cloudstack_network_acl_rule.foo", "rule.0.action", "allow"),
9092
resource.TestCheckResourceAttr(
@@ -99,6 +101,10 @@ func TestAccCloudStackNetworkACLRule_update(t *testing.T) {
99101
"cloudstack_network_acl_rule.foo", "rule.0.ports.0", "443"),
100102
resource.TestCheckResourceAttr(
101103
"cloudstack_network_acl_rule.foo", "rule.0.traffic_type", "ingress"),
104+
resource.TestCheckResourceAttr(
105+
"cloudstack_network_acl_rule.foo", "rule.0.reason", "Allow all traffic"),
106+
resource.TestCheckResourceAttr(
107+
"cloudstack_network_acl_rule.foo", "rule.1.number", "20"),
102108
resource.TestCheckResourceAttr(
103109
"cloudstack_network_acl_rule.foo", "rule.1.action", "allow"),
104110
resource.TestCheckResourceAttr(
@@ -111,6 +117,10 @@ func TestAccCloudStackNetworkACLRule_update(t *testing.T) {
111117
"cloudstack_network_acl_rule.foo", "rule.1.icmp_type", "-1"),
112118
resource.TestCheckResourceAttr(
113119
"cloudstack_network_acl_rule.foo", "rule.1.traffic_type", "ingress"),
120+
resource.TestCheckResourceAttr(
121+
"cloudstack_network_acl_rule.foo", "rule.1.description", "Allow ICMP traffic"),
122+
resource.TestCheckResourceAttr(
123+
"cloudstack_network_acl_rule.foo", "rule.2.description", "Allow HTTP and HTTPS"),
114124
),
115125
},
116126

@@ -298,7 +308,6 @@ resource "cloudstack_network_acl_rule" "foo" {
298308
}
299309
300310
rule {
301-
rule_number = 10
302311
action = "deny"
303312
cidr_list = ["172.18.100.0/24", "172.18.101.0/24"]
304313
protocol = "icmp"
@@ -309,7 +318,6 @@ resource "cloudstack_network_acl_rule" "foo" {
309318
}
310319
311320
rule {
312-
rule_number = 20
313321
action = "allow"
314322
cidr_list = ["172.18.100.0/24"]
315323
protocol = "tcp"

0 commit comments

Comments
 (0)