build: don't link directly against ffmpeg

Author: silenium-dev

native/CMakeLists.txt

@@ -51,10 +51,10 @@ target_include_directories(${PROJECT_NAME} PRIVATE "src/cpp/")
 
 message(STATUS "JAVA_HOME: ${JAVA_HOME}")
 target_include_directories(${PROJECT_NAME} PUBLIC "${JAVA_HOME}/include")
-if (NOT USE_SYSTEM_FFMPEG)
-    target_link_libraries(${PROJECT_NAME} PUBLIC -Wl,--push-state,--whole-archive,--allow-multiple-definition ffmpeg -Wl,--pop-state)
-    add_custom_command(TARGET ${PROJECT_NAME} POST_BUILD COMMAND objcopy --localize-hidden --strip-all --strip-unneeded $<TARGET_FILE:${PROJECT_NAME}>)
-endif ()
+#if (NOT USE_SYSTEM_FFMPEG)
+#    target_link_libraries(${PROJECT_NAME} PUBLIC -Wl,--push-state,--whole-archive,--allow-multiple-definition ffmpeg -Wl,--pop-state)
+#    add_custom_command(TARGET ${PROJECT_NAME} POST_BUILD COMMAND objcopy --localize-hidden --strip-all --strip-unneeded $<TARGET_FILE:${PROJECT_NAME}>)
+#endif ()
 
 if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
     target_compile_definitions(${PROJECT_NAME} PRIVATE -D_LINUX)
@@ -63,10 +63,10 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
     pkg_check_modules(MPV REQUIRED IMPORTED_TARGET mpv)
     target_link_libraries(${PROJECT_NAME} PUBLIC PkgConfig::GL PkgConfig::MPV)
     target_include_directories(${PROJECT_NAME} PUBLIC "${JAVA_HOME}/include/linux")
-    if (USE_SYSTEM_FFMPEG)
-        pkg_check_modules(FFMPEG REQUIRED IMPORTED_TARGET libavcodec libavformat libavutil libswscale libavfilter)
-        target_link_libraries(${PROJECT_NAME} PRIVATE PkgConfig::FFMPEG)
-    endif ()
+#    if (USE_SYSTEM_FFMPEG)
+#        pkg_check_modules(FFMPEG REQUIRED IMPORTED_TARGET libavcodec libavformat libavutil libswscale libavfilter)
+#        target_link_libraries(${PROJECT_NAME} PRIVATE PkgConfig::FFMPEG)
+#    endif ()
 elseif (CMAKE_SYSTEM_NAME STREQUAL "Windows")
     target_compile_definitions(${PROJECT_NAME} PRIVATE -D_WINDOWS)
     target_link_libraries(${PROJECT_NAME} PUBLIC opengl32 dxgi d3d11 d3dcompiler)

native/src/cpp/helper/errors.cpp

@@ -8,16 +8,6 @@
 #include <GL/gl.h>
 #include <iostream>
 
-extern "C" {
-#include <libavutil/error.h>
-}
-
-std::string avErrorString(const int error) {
-    char errorString[AV_ERROR_MAX_STRING_SIZE];
-    av_strerror(error, errorString, AV_ERROR_MAX_STRING_SIZE);
-    return {errorString};
-}
-
 jobject boxedLong(JNIEnv *env, const long value) {
     const auto boxedClass = env->FindClass("java/lang/Long");
     const auto constructor = env->GetMethodID(boxedClass, "<init>", "(J)V");