Skip to content

Commit 89ae0cc

Browse files
fix: exportFilename generates PDF outside dist folder and creates incorrect download links (#2313)
1 parent 5c0b51f commit 89ae0cc

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/slidev/node/commands/build.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,11 @@ export async function build(
138138
}),
139139
)
140140
server.listen(port)
141+
const filename = options.data.config.exportFilename || 'slidev-exported'
141142
await exportSlides({
142143
port,
143144
base: config.base,
144-
...getExportOptions(args, options, join(outDir, 'slidev-exported.pdf')),
145+
...getExportOptions(args, options, join(outDir, `${filename}.pdf`)),
145146
})
146147
server.close()
147148
}

packages/slidev/node/commands/export.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ export function getExportOptions(args: ExportArgs, options: ResolvedSlidevOption
587587
scale,
588588
omitBackground,
589589
} = config
590-
outFilename = output || options.data.config.exportFilename || outFilename || `${path.basename(entry, '.md')}-export`
590+
outFilename = output || outFilename || options.data.config.exportFilename || `${path.basename(entry, '.md')}-export`
591591
return {
592592
output: outFilename,
593593
slides: options.data.slides,

0 commit comments

Comments
 (0)