From d6c361f4003e22ad6845cdea21a79613c750c605 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 14:44:35 -0300 Subject: [PATCH 01/18] prevent breaking o11y with idl changes --- .github/workflows/idl-compatibility-check.yml | 84 +++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 .github/workflows/idl-compatibility-check.yml diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml new file mode 100644 index 000000000..1f9dbc025 --- /dev/null +++ b/.github/workflows/idl-compatibility-check.yml @@ -0,0 +1,84 @@ +name: IDL Compatibility Check + +on: + pull_request: + paths: + - "chains/solana/contracts/target/idl/**" + types: [opened, synchronize, reopened, labeled] + +jobs: + check-idl-changes: + runs-on: ubuntu-latest + permissions: + pull-requests: write + contents: read + steps: + - name: Checkout code + uses: actions/checkout@v3 + with: + fetch-depth: 0 + + - name: Check for bypass label + id: check-bypass + uses: actions/github-script@v6 + with: + script: | + // Check if PR has bypass label + const { data: labels } = await github.rest.issues.listLabelsOnIssue({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number + }); + + if (labels.some(label => label.name === 'idl-check-confirmed')) { + console.log('IDL check bypass label found'); + return true; + } + + return false; + + - name: List changed IDL files + id: changed-files + uses: actions/github-script@v6 + with: + script: | + const { execSync } = require('child_process'); + const changedFiles = execSync('git diff --name-only origin/${{ github.base_ref }} HEAD -- chains/solana/contracts/target/idl/').toString().trim().split('\n'); + console.log('Changed IDL files:'); + changedFiles.forEach(file => console.log(`- ${file}`)); + return { changedFiles }; + + - name: Comment on PR + if: steps.check-bypass.outputs.result == 'false' + uses: actions/github-script@v6 + with: + script: | + const changedFiles = JSON.parse(steps.changed-files.outputs.result).changedFiles; + + // Build list of changed files + const filesList = changedFiles.map(file => `- \`${file}\``).join('\n'); + + const commentBody = [ + '## ⚠️ IDL Compatibility Check Required ⚠️', + '', + '### Changes detected in IDL files:', + filesList, + '', + '⚠️ **IMPORTANT**: Please verify that these changes maintain compatibility with our observability pipeline!', + '', + '#### To bypass this check:', + '- Add the `idl-check-confirmed` label to this PR' + ].join('\n'); + + await github.rest.issues.createComment({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + body: commentBody + }); + + - name: Fail if no bypass + if: steps.check-bypass.outputs.result == 'false' + run: | + echo "::error::IDL changes detected - Please confirm compatibility with observability pipeline" + exit 1 From 1eedbef68553d4623e4147dbef52041722c25433 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 14:49:31 -0300 Subject: [PATCH 02/18] test change idl --- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index a0001b1b5..459d38dc8 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -1973,7 +1973,7 @@ ] }, { - "name": "OwnershipTransferred", + "name": "OwnershipTransferred ", "fields": [ { "name": "from", From c8e494f85184cf4e3a020c03e6d4064dbd11c7d3 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 14:52:20 -0300 Subject: [PATCH 03/18] fix action --- .github/workflows/idl-compatibility-check.yml | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index 1f9dbc025..84a26a484 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -39,21 +39,19 @@ jobs: - name: List changed IDL files id: changed-files - uses: actions/github-script@v6 - with: - script: | - const { execSync } = require('child_process'); - const changedFiles = execSync('git diff --name-only origin/${{ github.base_ref }} HEAD -- chains/solana/contracts/target/idl/').toString().trim().split('\n'); - console.log('Changed IDL files:'); - changedFiles.forEach(file => console.log(`- ${file}`)); - return { changedFiles }; + run: | + CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }} HEAD -- chains/solana/contracts/target/idl/) + echo "::set-output name=files::$CHANGED_FILES" + echo "Changed files:" + echo "$CHANGED_FILES" - name: Comment on PR - if: steps.check-bypass.outputs.result == 'false' + if: steps.check-bypass.outputs.result != 'true' uses: actions/github-script@v6 with: script: | - const changedFiles = JSON.parse(steps.changed-files.outputs.result).changedFiles; + // Get changed files from the previous step + const changedFiles = `${{ steps.changed-files.outputs.files }}`.trim().split('\n'); // Build list of changed files const filesList = changedFiles.map(file => `- \`${file}\``).join('\n'); @@ -78,7 +76,7 @@ jobs: }); - name: Fail if no bypass - if: steps.check-bypass.outputs.result == 'false' + if: steps.check-bypass.outputs.result != 'true' run: | echo "::error::IDL changes detected - Please confirm compatibility with observability pipeline" exit 1 From 9d49fa4ae86ce94c9b1f107487a6fd82a888ad8b Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 14:59:36 -0300 Subject: [PATCH 04/18] fix --- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index 459d38dc8..a0001b1b5 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -1973,7 +1973,7 @@ ] }, { - "name": "OwnershipTransferred ", + "name": "OwnershipTransferred", "fields": [ { "name": "from", From 8378c29b5128fd1913116f0f0a64835bf0ff5d70 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:01:38 -0300 Subject: [PATCH 05/18] change in idl --- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index a0001b1b5..459d38dc8 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -1973,7 +1973,7 @@ ] }, { - "name": "OwnershipTransferred", + "name": "OwnershipTransferred ", "fields": [ { "name": "from", From dff540c6e2ca3b69f95a851dcc4874c64c2fbb3b Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:14:07 -0300 Subject: [PATCH 06/18] only ones we need to track --- .github/workflows/idl-compatibility-check.yml | 28 ++++++++++++++++--- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index 84a26a484..6f3d5dd1c 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -3,7 +3,13 @@ name: IDL Compatibility Check on: pull_request: paths: - - "chains/solana/contracts/target/idl/**" + - "chains/solana/contracts/target/idl/base_token_pool.json" + - "chains/solana/contracts/target/idl/ccip_common.json" + - "chains/solana/contracts/target/idl/ccip_offramp.json" + - "chains/solana/contracts/target/idl/ccip_router.json" + - "chains/solana/contracts/target/idl/cctp_token_pool.json" + - "chains/solana/contracts/target/idl/fee_quoter.json" + - "chains/solana/contracts/target/idl/rmn_remote.json" types: [opened, synchronize, reopened, labeled] jobs: @@ -40,8 +46,16 @@ jobs: - name: List changed IDL files id: changed-files run: | - CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }} HEAD -- chains/solana/contracts/target/idl/) - echo "::set-output name=files::$CHANGED_FILES" + # Only check specific files that impact observability + CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }} HEAD -- \ + chains/solana/contracts/target/idl/base_token_pool.json \ + chains/solana/contracts/target/idl/ccip_common.json \ + chains/solana/contracts/target/idl/ccip_offramp.json \ + chains/solana/contracts/target/idl/ccip_router.json \ + chains/solana/contracts/target/idl/cctp_token_pool.json \ + chains/solana/contracts/target/idl/fee_quoter.json \ + chains/solana/contracts/target/idl/rmn_remote.json) + echo "files=$CHANGED_FILES" >> $GITHUB_OUTPUT echo "Changed files:" echo "$CHANGED_FILES" @@ -53,6 +67,12 @@ jobs: // Get changed files from the previous step const changedFiles = `${{ steps.changed-files.outputs.files }}`.trim().split('\n'); + // Skip empty results (no files changed) + if (changedFiles.length === 0 || (changedFiles.length === 1 && changedFiles[0] === '')) { + console.log('No monitored IDL files changed'); + return; + } + // Build list of changed files const filesList = changedFiles.map(file => `- \`${file}\``).join('\n'); @@ -76,7 +96,7 @@ jobs: }); - name: Fail if no bypass - if: steps.check-bypass.outputs.result != 'true' + if: steps.check-bypass.outputs.result != 'true' && steps.changed-files.outputs.files != '' run: | echo "::error::IDL changes detected - Please confirm compatibility with observability pipeline" exit 1 From 410df7d62e574633b5cfcd1c2f5136eda7f53eee Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:16:01 -0300 Subject: [PATCH 07/18] Revert "change in idl" This reverts commit 8378c29b5128fd1913116f0f0a64835bf0ff5d70. --- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index 459d38dc8..a0001b1b5 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -1973,7 +1973,7 @@ ] }, { - "name": "OwnershipTransferred ", + "name": "OwnershipTransferred", "fields": [ { "name": "from", From c4e8ef2ba86671b041dd7e73e54cb3909dba7c78 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:24:46 -0300 Subject: [PATCH 08/18] shouldn't trigger --- chains/solana/contracts/target/idl/access_controller.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chains/solana/contracts/target/idl/access_controller.json b/chains/solana/contracts/target/idl/access_controller.json index 6b8dad08d..25939efba 100644 --- a/chains/solana/contracts/target/idl/access_controller.json +++ b/chains/solana/contracts/target/idl/access_controller.json @@ -109,7 +109,7 @@ ], "accounts": [ { - "name": "AccessController", + "name": "AccessController asdsad", "type": { "kind": "struct", "fields": [ From 1a8fd3dabf044fbc177ead8986204409b1b9be09 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:26:35 -0300 Subject: [PATCH 09/18] should detect multiple --- chains/solana/contracts/target/idl/ccip_common.json | 2 +- chains/solana/contracts/target/idl/ccip_offramp.json | 2 +- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/chains/solana/contracts/target/idl/ccip_common.json b/chains/solana/contracts/target/idl/ccip_common.json index 60dadcbaf..54dd413c5 100644 --- a/chains/solana/contracts/target/idl/ccip_common.json +++ b/chains/solana/contracts/target/idl/ccip_common.json @@ -4,7 +4,7 @@ "instructions": [], "accounts": [ { - "name": "TokenAdminRegistry", + "name": "TokenAdminRegistry ", "type": { "kind": "struct", "fields": [ diff --git a/chains/solana/contracts/target/idl/ccip_offramp.json b/chains/solana/contracts/target/idl/ccip_offramp.json index 3469ab165..0996c99b4 100644 --- a/chains/solana/contracts/target/idl/ccip_offramp.json +++ b/chains/solana/contracts/target/idl/ccip_offramp.json @@ -12,7 +12,7 @@ ], "instructions": [ { - "name": "initialize", + "name": "initialize ", "docs": [ "Initialization Flow //", "Initializes the CCIP Offramp, except for the config account (due to stack size limitations).", diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index a0001b1b5..459d38dc8 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -1973,7 +1973,7 @@ ] }, { - "name": "OwnershipTransferred", + "name": "OwnershipTransferred ", "fields": [ { "name": "from", From 8405c4308658876cb58a4d5fe694597c0ca3f8ce Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:30:04 -0300 Subject: [PATCH 10/18] fix actin --- .github/workflows/idl-compatibility-check.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index 6f3d5dd1c..4e6249895 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -54,7 +54,7 @@ jobs: chains/solana/contracts/target/idl/ccip_router.json \ chains/solana/contracts/target/idl/cctp_token_pool.json \ chains/solana/contracts/target/idl/fee_quoter.json \ - chains/solana/contracts/target/idl/rmn_remote.json) + chains/solana/contracts/target/idl/rmn_remote.json | tr '\n' ' ') echo "files=$CHANGED_FILES" >> $GITHUB_OUTPUT echo "Changed files:" echo "$CHANGED_FILES" @@ -64,11 +64,11 @@ jobs: uses: actions/github-script@v6 with: script: | - // Get changed files from the previous step - const changedFiles = `${{ steps.changed-files.outputs.files }}`.trim().split('\n'); + // Get changed files from the previous step (now space-separated) + const changedFiles = `${{ steps.changed-files.outputs.files }}`.trim().split(' ').filter(Boolean); // Skip empty results (no files changed) - if (changedFiles.length === 0 || (changedFiles.length === 1 && changedFiles[0] === '')) { + if (changedFiles.length === 0) { console.log('No monitored IDL files changed'); return; } From 0ec0a4e3237a8bb1a2312e2bdcea204ac4165240 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:35:23 -0300 Subject: [PATCH 11/18] Revert "should detect multiple" This reverts commit 1a8fd3dabf044fbc177ead8986204409b1b9be09. --- chains/solana/contracts/target/idl/ccip_common.json | 2 +- chains/solana/contracts/target/idl/ccip_offramp.json | 2 +- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/chains/solana/contracts/target/idl/ccip_common.json b/chains/solana/contracts/target/idl/ccip_common.json index 54dd413c5..60dadcbaf 100644 --- a/chains/solana/contracts/target/idl/ccip_common.json +++ b/chains/solana/contracts/target/idl/ccip_common.json @@ -4,7 +4,7 @@ "instructions": [], "accounts": [ { - "name": "TokenAdminRegistry ", + "name": "TokenAdminRegistry", "type": { "kind": "struct", "fields": [ diff --git a/chains/solana/contracts/target/idl/ccip_offramp.json b/chains/solana/contracts/target/idl/ccip_offramp.json index 0996c99b4..3469ab165 100644 --- a/chains/solana/contracts/target/idl/ccip_offramp.json +++ b/chains/solana/contracts/target/idl/ccip_offramp.json @@ -12,7 +12,7 @@ ], "instructions": [ { - "name": "initialize ", + "name": "initialize", "docs": [ "Initialization Flow //", "Initializes the CCIP Offramp, except for the config account (due to stack size limitations).", diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index 459d38dc8..a0001b1b5 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -1973,7 +1973,7 @@ ] }, { - "name": "OwnershipTransferred ", + "name": "OwnershipTransferred", "fields": [ { "name": "from", From 8478ee11cdf03f4c9904576a503729fe4cfb2669 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:36:28 -0300 Subject: [PATCH 12/18] Revert "shouldn't trigger" This reverts commit c4e8ef2ba86671b041dd7e73e54cb3909dba7c78. --- chains/solana/contracts/target/idl/access_controller.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chains/solana/contracts/target/idl/access_controller.json b/chains/solana/contracts/target/idl/access_controller.json index 25939efba..6b8dad08d 100644 --- a/chains/solana/contracts/target/idl/access_controller.json +++ b/chains/solana/contracts/target/idl/access_controller.json @@ -109,7 +109,7 @@ ], "accounts": [ { - "name": "AccessController asdsad", + "name": "AccessController", "type": { "kind": "struct", "fields": [ From 83c12ad07967e8c5f4de22685b3825ffbe7aff13 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:39:09 -0300 Subject: [PATCH 13/18] fix some comms --- .github/workflows/idl-compatibility-check.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index 4e6249895..d7ae363f3 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -29,7 +29,6 @@ jobs: uses: actions/github-script@v6 with: script: | - // Check if PR has bypass label const { data: labels } = await github.rest.issues.listLabelsOnIssue({ owner: context.repo.owner, repo: context.repo.repo, @@ -46,7 +45,7 @@ jobs: - name: List changed IDL files id: changed-files run: | - # Only check specific files that impact observability + # Only check specific files to reduce noise CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }} HEAD -- \ chains/solana/contracts/target/idl/base_token_pool.json \ chains/solana/contracts/target/idl/ccip_common.json \ @@ -64,18 +63,14 @@ jobs: uses: actions/github-script@v6 with: script: | - // Get changed files from the previous step (now space-separated) const changedFiles = `${{ steps.changed-files.outputs.files }}`.trim().split(' ').filter(Boolean); - // Skip empty results (no files changed) if (changedFiles.length === 0) { console.log('No monitored IDL files changed'); return; } - // Build list of changed files const filesList = changedFiles.map(file => `- \`${file}\``).join('\n'); - const commentBody = [ '## ⚠️ IDL Compatibility Check Required ⚠️', '', From 79a1d6c4773ad6c82e084ee4b54682f940f65a32 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:47:19 -0300 Subject: [PATCH 14/18] add unlabeled --- .github/workflows/idl-compatibility-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index d7ae363f3..9a828e0f1 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -10,7 +10,7 @@ on: - "chains/solana/contracts/target/idl/cctp_token_pool.json" - "chains/solana/contracts/target/idl/fee_quoter.json" - "chains/solana/contracts/target/idl/rmn_remote.json" - types: [opened, synchronize, reopened, labeled] + types: [opened, synchronize, reopened, labeled, unlabeled] jobs: check-idl-changes: From b47dd70bcc5287d1fd4793473cf7f0d4e3ece13a Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:48:12 -0300 Subject: [PATCH 15/18] should trigger --- chains/solana/contracts/target/idl/ccip_common.json | 2 +- chains/solana/contracts/target/idl/ccip_offramp.json | 2 +- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/chains/solana/contracts/target/idl/ccip_common.json b/chains/solana/contracts/target/idl/ccip_common.json index 60dadcbaf..54dd413c5 100644 --- a/chains/solana/contracts/target/idl/ccip_common.json +++ b/chains/solana/contracts/target/idl/ccip_common.json @@ -4,7 +4,7 @@ "instructions": [], "accounts": [ { - "name": "TokenAdminRegistry", + "name": "TokenAdminRegistry ", "type": { "kind": "struct", "fields": [ diff --git a/chains/solana/contracts/target/idl/ccip_offramp.json b/chains/solana/contracts/target/idl/ccip_offramp.json index 3469ab165..8cb880311 100644 --- a/chains/solana/contracts/target/idl/ccip_offramp.json +++ b/chains/solana/contracts/target/idl/ccip_offramp.json @@ -150,7 +150,7 @@ "returns": "string" }, { - "name": "transferOwnership", + "name": "transferOwnership ", "docs": [ "Transfers the ownership of the router to a new proposed owner.", "", diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index a0001b1b5..5f687bf92 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -13,7 +13,7 @@ ], "instructions": [ { - "name": "initialize", + "name": "initialize ", "docs": [ "Initialization Flow //", "Initializes the CCIP Router.", From 0b365b3f20920d6dcf13da3d71e8018f3deeafae Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:50:13 -0300 Subject: [PATCH 16/18] Revert "add unlabeled" This reverts commit 79a1d6c4773ad6c82e084ee4b54682f940f65a32. --- .github/workflows/idl-compatibility-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index 9a828e0f1..d7ae363f3 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -10,7 +10,7 @@ on: - "chains/solana/contracts/target/idl/cctp_token_pool.json" - "chains/solana/contracts/target/idl/fee_quoter.json" - "chains/solana/contracts/target/idl/rmn_remote.json" - types: [opened, synchronize, reopened, labeled, unlabeled] + types: [opened, synchronize, reopened, labeled] jobs: check-idl-changes: From 0d2484a1778bed9535a70c550157ba1512125711 Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:51:05 -0300 Subject: [PATCH 17/18] unlabeled --- .github/workflows/idl-compatibility-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idl-compatibility-check.yml b/.github/workflows/idl-compatibility-check.yml index d7ae363f3..9a828e0f1 100644 --- a/.github/workflows/idl-compatibility-check.yml +++ b/.github/workflows/idl-compatibility-check.yml @@ -10,7 +10,7 @@ on: - "chains/solana/contracts/target/idl/cctp_token_pool.json" - "chains/solana/contracts/target/idl/fee_quoter.json" - "chains/solana/contracts/target/idl/rmn_remote.json" - types: [opened, synchronize, reopened, labeled] + types: [opened, synchronize, reopened, labeled, unlabeled] jobs: check-idl-changes: From f592f0cd27d810f2ac1f916508f1f99f9583a3ac Mon Sep 17 00:00:00 2001 From: Farber98 Date: Mon, 6 Oct 2025 15:51:28 -0300 Subject: [PATCH 18/18] Revert "should trigger" This reverts commit b47dd70bcc5287d1fd4793473cf7f0d4e3ece13a. --- chains/solana/contracts/target/idl/ccip_common.json | 2 +- chains/solana/contracts/target/idl/ccip_offramp.json | 2 +- chains/solana/contracts/target/idl/ccip_router.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/chains/solana/contracts/target/idl/ccip_common.json b/chains/solana/contracts/target/idl/ccip_common.json index 54dd413c5..60dadcbaf 100644 --- a/chains/solana/contracts/target/idl/ccip_common.json +++ b/chains/solana/contracts/target/idl/ccip_common.json @@ -4,7 +4,7 @@ "instructions": [], "accounts": [ { - "name": "TokenAdminRegistry ", + "name": "TokenAdminRegistry", "type": { "kind": "struct", "fields": [ diff --git a/chains/solana/contracts/target/idl/ccip_offramp.json b/chains/solana/contracts/target/idl/ccip_offramp.json index 8cb880311..3469ab165 100644 --- a/chains/solana/contracts/target/idl/ccip_offramp.json +++ b/chains/solana/contracts/target/idl/ccip_offramp.json @@ -150,7 +150,7 @@ "returns": "string" }, { - "name": "transferOwnership ", + "name": "transferOwnership", "docs": [ "Transfers the ownership of the router to a new proposed owner.", "", diff --git a/chains/solana/contracts/target/idl/ccip_router.json b/chains/solana/contracts/target/idl/ccip_router.json index 5f687bf92..a0001b1b5 100644 --- a/chains/solana/contracts/target/idl/ccip_router.json +++ b/chains/solana/contracts/target/idl/ccip_router.json @@ -13,7 +13,7 @@ ], "instructions": [ { - "name": "initialize ", + "name": "initialize", "docs": [ "Initialization Flow //", "Initializes the CCIP Router.",