fix: removing chainlink-common dep as direct dependency (#524)

Attempt to remove dependency on chainlink-common, cloning the required
interface for logger and keystore interface
However we still have indirect dependency on chainlink-common from our
other dependencies.

We want to remove dependency on `chainlink-common` because we use it
only for the logger, and `chainlink-common` tend to have breaking
changes with bad versioning.

Chainlink repo run with this commit -
smartcontractkit/chainlink#19967 - everything
compiled normally

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-777

Author: graham-chainlink

.changeset/thin-apes-pump.md

@@ -0,0 +1,5 @@
+---
+"chainlink-deployments-framework": patch
+---
+
+fix: remove dep on chainlink-common

.golangci.yml

@@ -70,13 +70,17 @@ linters:
             - pkg: github.com/pelletier/go-toml$
               desc: Use github.com/pelletier/go-toml/v2 instead
             - pkg: github.com/smartcontractkit/chainlink/v2/core/logger
-              desc: Use github.com/smartcontractkit/chainlink-common/pkg/logger instead
+              desc: Use github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger instead
             - pkg: github.com/pkg/errors
               desc: Use the standard library instead, for example https://pkg.go.dev/fmt#Errorf
             - pkg: github.com/smartcontractkit/chainlink/v2
               desc: You must not import this package. There is no alternative.
             - pkg: github.com/smartcontractkit/chainlink/deployment
               desc: You must not import this package. There is no alternative.
+            - pkg: github.com/smartcontractkit/chainlink-common/pkg/logger
+              desc: Use github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger instead
+            - pkg: github.com/smartcontractkit/chainlink-common
+              desc: We want to avoid importing this package as it has regular breaking changes.
     goconst:
       min-len: 5
     govet:

chain/evm/provider/ctf_anvil_provider.go

@@ -218,12 +218,13 @@ import (
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	"github.com/ethereum/go-ethereum/crypto"
 	chainsel "github.com/smartcontractkit/chain-selectors"
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 	"github.com/smartcontractkit/freeport"
 	"github.com/testcontainers/testcontainers-go"
 
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
+
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm/provider/rpcclient"

chain/evm/provider/ctf_geth_provider.go

@@ -223,12 +223,13 @@ import (
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/crypto"
 	chainsel "github.com/smartcontractkit/chain-selectors"
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 	"github.com/smartcontractkit/freeport"
 	"github.com/testcontainers/testcontainers-go"
 
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
+
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm/provider/rpcclient"

chain/evm/provider/rpc_provider.go

@@ -8,7 +8,8 @@ import (
 
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	chainsel "github.com/smartcontractkit/chain-selectors"
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
+
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
 
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"

chain/evm/provider/rpc_provider_test.go

@@ -5,10 +5,11 @@ import (
 	"time"
 
 	chainsel "github.com/smartcontractkit/chain-selectors"
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
+
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm/provider/rpcclient"
 )

chain/evm/provider/rpcclient/multiclient.go

@@ -17,7 +17,7 @@ import (
 	"github.com/ethereum/go-ethereum/rpc"
 	"github.com/google/uuid"
 
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
 
 	chainsel "github.com/smartcontractkit/chain-selectors"
 

chain/evm/provider/rpcclient/multiclient_test.go

@@ -12,7 +12,7 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
 )
 
 // Helper RPC server that always answers with a valid eth_blockNumber response

chain/evm/provider/zksync_rpc_provider.go

@@ -7,10 +7,11 @@ import (
 	"math/big"
 
 	chainsel "github.com/smartcontractkit/chain-selectors"
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	zkAccounts "github.com/zksync-sdk/zksync2-go/accounts"
 	zkClients "github.com/zksync-sdk/zksync2-go/clients"
 
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
+
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm/provider/rpcclient"

chain/evm/provider/zksync_rpc_provider_test.go

@@ -5,10 +5,11 @@ import (
 	"time"
 
 	chainsel "github.com/smartcontractkit/chain-selectors"
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
+	"github.com/smartcontractkit/chainlink-deployments-framework/pkg/logger"
+
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/evm/provider/rpcclient"
 )