Add discussion url input for proposal (#541)

* Add discussion input for proposal

* Add discussion field by default

* Update package.json

Co-authored-by: Chaitanya <[email protected]>

Author: bonustrack

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@snapshot-labs/snapshot.js",
-  "version": "0.3.57",
+  "version": "0.3.58",
   "repository": "snapshot-labs/snapshot.js",
   "license": "MIT",
   "main": "dist/snapshot.cjs.js",

src/client.ts

@@ -103,6 +103,7 @@ export default class Client {
     {
       name,
       body,
+      discussion = '',
       choices,
       start,
       end,
@@ -114,6 +115,7 @@ export default class Client {
     return this.broadcast(web3, address, space, 'proposal', {
       name,
       body,
+      discussion,
       choices,
       start,
       end,

src/schemas/proposal.json

@@ -18,6 +18,11 @@
           "minLength": 0,
           "maxLength": 14400
         },
+        "discussion": {
+          "type": "string",
+          "title": "discussion",
+          "maxLength": 256
+        },
         "choices": {
           "type": "array",
           "title": "choices",

src/sign/index.ts

@@ -86,6 +86,7 @@ export default class Client {
     address: string,
     message: Proposal
   ) {
+    if (!message.discussion) message.discussion = '';
     return await this.sign(web3, address, message, proposalTypes);
   }
 

src/sign/types.json

@@ -1,6 +1,7 @@
 {
   "110b37d3e2625cd6e1ec7b921e77773083b2a2949e69bd3a35fd9f1031ca5666": "settings",
   "a7bf2991bf4ff9053f1b19085ddc6febaa711e7a95cf90a797605dadc40b4079": "proposal",
+  "6fee59b7db10fabbb0c6420c0a18c9d2c36306e342042826a355bfc7fe733870": "proposal",
   "9ff8af4cfb586e2c7962d792b99328fb47e8a4e73cc89873c0980484bc1063a5": "delete-proposal",
   "734df82cdad586386defa4cb55adda7cb1b2a56929c4e6c3dc676f9901947288": "delete-proposal",
   "50084aae0fe117c83ddf855557dde35ae2872e9045443a15f72aa6c68ea3943b": "vote",

src/sign/types.ts

@@ -12,6 +12,7 @@ export interface Proposal {
   type: string;
   title: string;
   body: string;
+  discussion: string;
   choices: string[];
   start: number;
   end: number;
@@ -86,6 +87,7 @@ export const proposalTypes = {
     { name: 'type', type: 'string' },
     { name: 'title', type: 'string' },
     { name: 'body', type: 'string' },
+    { name: 'discussion', type: 'string' },
     { name: 'choices', type: 'string[]' },
     { name: 'start', type: 'uint64' },
     { name: 'end', type: 'uint64' },

test/examples/proposal.json

@@ -8,6 +8,7 @@
   "start": 1619884800,
   "end": 1620316800,
   "snapshot": 12345167,
+  "discussion": "https://...",
   "metadata": {
     "network": "1",
     "strategies": [