Skip to content

Commit ed5304c

Browse files
committed
fix: move out email subscription creation from profile
1 parent a61292a commit ed5304c

File tree

4 files changed

+6
-34
lines changed

4 files changed

+6
-34
lines changed

src/schemas/profile.json

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -52,23 +52,11 @@
5252
"pattern": "^[a-z0-9-]*$",
5353
"maxLength": 17
5454
},
55-
"emailSubscription": {
56-
"type": "object",
57-
"properties": {
58-
"email": {
59-
"type": "string",
60-
"title": "email",
61-
"maxLength": 256
62-
},
63-
"subscriptions": {
64-
"type": "array",
65-
"title": "subscriptions",
66-
"uniqueItems": true,
67-
"items": { "type": "string" }
68-
}
69-
},
70-
"required": [],
71-
"additionalProperties": false
55+
"emailSubscriptions": {
56+
"type": "array",
57+
"title": "email subscriptions",
58+
"uniqueItems": true,
59+
"items": { "type": "string" }
7260
}
7361
},
7462
"required": [],

test/examples/profile-addEmailSubscription.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

test/examples/profile-updateEmailSubscription.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,5 @@
22
"name": "Vitalik",
33
"avatar": "ipfs://NnVTdgcFciJUoxqgsNe9Hy2R7rgvEb5jDu5Pa5mmEG3UghbubTf2M78jUXbKLqKM",
44
"about": "This is my about info",
5-
"emailSubscription": {
6-
"subscriptions": ["summary", "newProposal"]
7-
}
5+
"emailSubscriptions": ["summary", "newProposal"]
86
}

test/schema.spec.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import spaceStarknetDelegation from './examples/space-starknet-delegation.json';
77
import proposalTurbo from './examples/proposal-turbo.json';
88
import vote from './examples/vote.json';
99
import profile from './examples/profile.json';
10-
import profileAddEmailSubscription from './examples/profile-addEmailSubscription.json';
1110
import profileUpdateEmailSubscription from './examples/profile-updateEmailSubscription.json';
1211
import statement from './examples/statement.json';
1312
import alias from './examples/alias.json';
@@ -26,11 +25,6 @@ describe.each([
2625
{ schemaType: 'proposal', schema: schemas.proposal, example: proposal },
2726
{ schemaType: 'vote', schema: schemas.vote, example: vote },
2827
{ schemaType: 'profile', schema: schemas.profile, example: profile },
29-
{
30-
schemaType: 'profile',
31-
schema: schemas.profile,
32-
example: profileAddEmailSubscription
33-
},
3428
{
3529
schemaType: 'profile',
3630
schema: schemas.profile,

0 commit comments

Comments
 (0)