Conversation
1 task
wa0x6e
changed the title
wa0x6e
marked this pull request as ready for review
October 27, 2024 21:46
ChaituVR
requested changes
Oct 28, 2024
wa0x6e
changed the title
ChaituVR
reviewed
Nov 4, 2024
wa0x6e
force-pushed
the
feat-ad-email-subscriptions-to-user
branch
from
November 12, 2024 11:27
37c15f3 to
071172e
Compare
wa0x6e
changed the title
ChaituVR
requested changes
Nov 13, 2024
wa0x6e
marked this pull request as draft
November 15, 2024 00:17
Contributor
Author
|
I am thinking that maybe, we should not use a generic |
Member
agree |
wa0x6e
changed the title
ChaituVR
requested changes
Nov 25, 2024
| import proposalTurbo from './examples/proposal-turbo.json'; | ||
| import vote from './examples/vote.json'; | ||
| import profile from './examples/profile.json'; | ||
| import subscription from './examples/subscription.json'; |
Member
There was a problem hiding this comment.
i think we should rename this file also to avoid confusions
Comment on lines
+2
to
+4
| "type": "email", | ||
| "value": "my-email@snapshot.org", | ||
| "metadata": "['summary', 'newProposal']" |
Member
There was a problem hiding this comment.
not sure what this file is for 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/226
Following snapshot-labs/snapshot-hub#951
This PR will add a new subscription/unsubscription features
subscriptionwill allow adding a new subscription when passing an email, and updating an existing subscription when just passing a metadatadelete-subscriptionwill allow deleting an existing subscriptionBy merging the write function from envelop (https://github.com/snapshot-labs/envelop/?tab=readme-ov-file#subscribe-to-the-mailing-list) into snapshot.js, then sequencer, we can leverage the signature and alias feature of sequencer, and will not require an extra handling of transaction signature.
How to tests
See snapshot-labs/snapshot-sequencer#470