Skip to content

Commit 6f73a7e

Browse files
authored
Fix v3 CI path filter case and remove stale files entry (#4465)
## Description Two small cleanups: - The path filter in `rngh-api-v3.yml` pointed at `API_V3.test.tsx`, but the file is `api_v3.test.tsx` and GitHub path filters are case-sensitive, so a PR touching only the v3 test suite never triggered the workflow. The mismatch has been there since the workflow was added in #3838. Also lowercased the pattern in the `yarn test` step to match the file literally (it worked before only because jest matches patterns case-insensitively). - Removed `android/common/src/main/java/` from `files` in `package.json` - the directory was deleted in #3544, npm silently ignores the unmatched entry. ## Test plan - `npx jest --listTests RelationsTraversal api_v3` still selects both test files.
1 parent a51bb25 commit 6f73a7e

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.github/workflows/rngh-api-v3.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
paths:
66
- packages/react-native-gesture-handler/src/v3/**
77
- packages/react-native-gesture-handler/src/__tests__/RelationsTraversal.test.tsx
8-
- packages/react-native-gesture-handler/src/__tests__/API_V3.test.tsx
8+
- packages/react-native-gesture-handler/src/__tests__/api_v3.test.tsx
99
push:
1010
branches:
1111
- main
@@ -35,4 +35,4 @@ jobs:
3535

3636
- name: Run tests
3737
working-directory: packages/react-native-gesture-handler
38-
run: yarn test RelationsTraversal API_V3
38+
run: yarn test RelationsTraversal api_v3

packages/react-native-gesture-handler/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
"android/src/main/AndroidManifest.xml",
3636
"android/src/main/java/",
3737
"android/src/main/jni/",
38-
"android/common/src/main/java/",
3938
"android/reanimated/src/main/java/",
4039
"android/noreanimated/src/main/java/",
4140
"android/svg",

0 commit comments

Comments
 (0)