SectionList long press

Author: m-bert

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt

@@ -392,8 +392,8 @@ class GestureHandlerOrchestrator(
   /**
    * Cancels handlers whose view opted out of surviving a native view taking over the touch stream.
    */
-  fun cancelHandlersOnNativeTouchGrab() = cancelTrackedHandlers {
-    it is NativeViewGestureHandler && it.shouldCancelOnNativeTouchGrab()
+  fun cancelHandlersOnNativeTouchGrab(grabbedMidGesture: Boolean) = cancelTrackedHandlers {
+    it is NativeViewGestureHandler && it.shouldCancelOnNativeTouchGrab(grabbedMidGesture)
   }
 
   /**

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/NativeViewGestureHandler.kt

@@ -241,7 +241,8 @@ class NativeViewGestureHandler : GestureHandler() {
 
   override fun wantsToAttachDirectlyToView() = true
 
-  fun shouldCancelOnNativeTouchGrab(): Boolean = hook.shouldCancelOnNativeTouchGrab()
+  fun shouldCancelOnNativeTouchGrab(grabbedMidGesture: Boolean): Boolean =
+    hook.shouldCancelOnNativeTouchGrab(grabbedMidGesture)
 
   data class HitSlop(
     val left: Float = HIT_SLOP_NONE,
@@ -364,10 +365,10 @@ class NativeViewGestureHandler : GestureHandler() {
     fun shouldRecognizeSimultaneously(handler: GestureHandler): Boolean? = null
 
     /**
-     * Called after a native view grabbed the touch lock during a native dispatch pass.
-     * Return true to cancel the handler.
+     * Called after a native view grabbed the touch lock; return true to cancel the handler.
+     * [grabbedMidGesture] distinguishes a real take-over from a defensive DOWN-pass disallow.
      */
-    fun shouldCancelOnNativeTouchGrab() = false
+    fun shouldCancelOnNativeTouchGrab(grabbedMidGesture: Boolean) = false
 
     /**
      * shouldActivateOnStart and tryIntercept have priority over this method

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt

@@ -748,8 +748,7 @@ class RNGestureHandlerButtonViewManager :
       val localLastEventWasInside = lastEventWasInside
 
       if (newState == GestureHandler.STATE_BEGAN) {
-        // Reset for the new gesture - BEGAN precedes the native dispatch of DOWN, which
-        // sets the flag.
+        // Reset for the new gesture - BEGAN precedes the native dispatch of DOWN that sets the flag.
         receivedNativeDown = false
         dispatchJSEvent(EventType.PressIn, handler)
         longPressDetected = false
@@ -830,7 +829,7 @@ class RNGestureHandlerButtonViewManager :
       return super.dispatchTouchEvent(event)
     }
 
-    override fun shouldCancelOnNativeTouchGrab() = !receivedNativeDown
+    override fun shouldCancelOnNativeTouchGrab(grabbedMidGesture: Boolean) = grabbedMidGesture || !receivedNativeDown
 
     override fun onInterceptTouchEvent(event: MotionEvent): Boolean {
       if (super.onInterceptTouchEvent(event)) {

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt

@@ -131,10 +131,10 @@ class RNGestureHandlerRootHelper(private val context: ReactContext, wrappedView:
    * defensive call from a view that lets the event through (e.g. a nested pager). The two can only
    * be told apart after the native dispatch completes, so cancellation runs here, not at request time.
    */
-  fun onNativeDispatchEnd() {
+  fun onNativeDispatchEnd(event: MotionEvent) {
     if (nativeTouchGrabRequested) {
       nativeTouchGrabRequested = false
-      orchestrator?.cancelHandlersOnNativeTouchGrab()
+      orchestrator?.cancelHandlersOnNativeTouchGrab(event.actionMasked != MotionEvent.ACTION_DOWN)
     }
   }
 

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootView.kt

@@ -63,7 +63,7 @@ class RNGestureHandlerRootView(context: Context?) : ReactViewGroup(context) {
       true
     } else {
       val handled = super.dispatchTouchEvent(event)
-      rootHelper?.onNativeDispatchEnd()
+      rootHelper?.onNativeDispatchEnd(event)
       handled
     }
   }