Ignore derived signals assigned to properties

Author: joshwilsonvu

src/rules/reactivity.ts

@@ -368,6 +368,8 @@ const rule: TSESLint.RuleModule<MessageIds, []> = {
             } else {
               pushUnnamedDerivedSignal();
             }
+          } else if (currentScopeNode.parent?.type === "Property") {
+            // todo make this a unique props or something--for now, just ignore (unsafe)
           } else {
             pushUnnamedDerivedSignal();
           }
@@ -876,12 +878,14 @@ const rule: TSESLint.RuleModule<MessageIds, []> = {
         } else if (/^(?:use|create)[A-Z]/.test(callee.name)) {
           // Custom hooks parameters may or may not be tracking scopes, no way to know.
           // Assume all identifier/function arguments are tracked scopes, and use "called-function"
-          // to allow async handlers (permissive)
-          node.arguments
-            .filter((arg) => isFunctionNode(arg) || arg.type === "Identifier")
-            .forEach((arg) => {
+          // to allow async handlers (permissive). Assume non-resolvable args are reactive expressions.
+          for (const arg of node.arguments) {
+            if (isFunctionNode(arg)) {
               pushTrackedScope(arg, "called-function");
-            });
+            } else if (arg.type === "Identifier" || arg.type === "ObjectExpression") {
+              pushTrackedScope(arg, "expression");
+            }
+          }
         }
       } else if (node.type === "CallExpression" && node.callee.type === "MemberExpression") {
         const { property } = node.callee;

test/rules/reactivity.test.ts

@@ -143,13 +143,16 @@ export const cases = run("reactivity", rule, {
     `const [a, setA] = createSignal(1);
     const [b] = createSignal(2);
     on(b, async () => { await delay(1000); setA(a() + 1) });`,
+    // Custom hooks
     `const Component = (props) => {
       const localRef = () => props.ref;
-      // custom hooks
       const composedRef1 = useComposedRefs(localRef);
       const composedRef2 = useComposedRefs(() => props.ref);
       const composedRef3 = createComposedRefs(localRef);
     }`,
+    `function createFoo(v) {}
+    const [bar, setBar] = createSignal();
+    createFoo({ onBar: () => bar() });`,
     // Event listeners
     `const [signal, setSignal] = createSignal(1);
     const element = document.getElementById("id");