Add shellcheck for tests

Author: solidnerd

.circleci/config.yml

@@ -1,6 +1,16 @@
 version: 2
 
 jobs:
+  shellcheck:
+    docker:
+      - image: nlknguyen/alpine-shellcheck:v0.4.6
+    steps:
+      - checkout
+      - run:
+          name: Check Scripts
+          command: |
+            find . -type f -name '*.sh' | wc -l
+            find . -type f -name '*.sh' | xargs shellcheck --external-sources
   validate_terraform:
     docker:
       - image: hashicorp/terraform
@@ -14,4 +24,5 @@ workflows:
   version: 2
   validate:
     jobs:
+      - shellcheck
       - validate_terraform

install-plugin.sh

@@ -4,11 +4,11 @@ OS=${OS:-darwin}
 HCLOUD_VERSION=${HCLOUD_VERSION:-1.1.0}
 HCLOUD_TERRAFORM_URL=${HCLOUD_TERRAFORM_URL:-"https://github.com/hetznercloud/terraform-provider-hcloud/releases/download/v${HCLOUD_VERSION}/terraform-provider-hcloud_v${HCLOUD_VERSION}_${OS}_amd64.zip"}
 echo "Install Terraform plugin from:"
-echo "$HCLOUD_TERRAFORM_URL"
-curl -sSL $HCLOUD_TERRAFORM_URL -o terraform-provider-hcloud_v${HCLOUD_VERSION}_${OS}_amd64.zip
+echo "${HCLOUD_TERRAFORM_URL}"
+curl -sSL "${HCLOUD_TERRAFORM_URL}" -o terraform-provider-hcloud_v"${HCLOUD_VERSION}"_"${OS}"_amd64.zip
 
-unzip -d /tmp/terraform-provider-hcloud_v${HCLOUD_VERSION}_${OS}_amd64 terraform-provider-hcloud_v${HCLOUD_VERSION}_${OS}_amd64.zip
+unzip -d /tmp/terraform-provider-hcloud_v"${HCLOUD_VERSION}"_"${OS}"_amd64 terraform-provider-hcloud_v"${HCLOUD_VERSION}"_"${OS}"_amd64.zip
 
 mkdir -p ~/.terraform.d/plugins/
 
-mv -v /tmp/terraform-provider-hcloud_v${HCLOUD_VERSION}_${OS}_amd64/terraform-provider-hcloud ~/.terraform.d/plugins/terraform-provider-hcloud
+mv -v /tmp/terraform-provider-hcloud_v"${HCLOUD_VERSION}"_"${OS}"_amd64/terraform-provider-hcloud ~/.terraform.d/plugins/terraform-provider-hcloud

scripts/copy-kubeadm-token.sh

@@ -6,14 +6,14 @@ SSH_HOST=${SSH_HOST:-}
 
 TARGET=${TARGET:-}
 
-mkdir -p ${TARGET}
+mkdir -p "${TARGET}"
 
 scp -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null \
-    -i ${SSH_PRIVATE_KEY} \
-    ${SSH_USERNAME}@${SSH_HOST}:"/tmp/kubeadm_join" \
-    ${TARGET}
+    -i "${SSH_PRIVATE_KEY}" \
+    "${SSH_USERNAME}@${SSH_HOST}:/tmp/kubeadm_join" \
+    "${TARGET}"
 
 scp -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null \
-    -i ${SSH_PRIVATE_KEY} \
-    ${SSH_USERNAME}@${SSH_HOST}:"/etc/kubernetes/admin.conf" \
-    ${TARGET}
+    -i "${SSH_PRIVATE_KEY}" \
+    "${SSH_USERNAME}@${SSH_HOST}:/etc/kubernetes/admin.conf" \
+    "${TARGET}"

scripts/master.sh

@@ -13,7 +13,7 @@ Pin-Priority: 1000
 apt-get install -qq -y kubectl
 
 # Initialize Cluster
-kubeadm init --feature-gates CoreDNS=$CORE_DNS
+kubeadm init --feature-gates CoreDNS="$CORE_DNS"
 
 systemctl enable docker kubelet
 

scripts/node.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/bash
 set -eu
 
-eval $(cat /tmp/kubeadm_join)
+eval "$(cat /tmp/kubeadm_join)"
 systemctl enable docker kubelet