-
-
Notifications
You must be signed in to change notification settings - Fork 123
Description
I’m using a vanilla Solidus 2.4.2 store with solidus_auth_devised.
It looks like the default user created has email: [email protected]
and login: [email protected]
. If I go to the /account/edit
page, I can modify the User’s email
.
Now I have a situation where I have email: [email protected]
and login: [email protected]
. It seems there is simply no way to modify the login
attribute once the user is created. What’s slightly weirder, it is email
, not login
, that is used to log in. :)
What should we do here?
My suggestion would be that if this extension is built to use the email
attribute as the login by default, than we should either:
- leave the actual
login
attribute asnil
when creating a new user. - save any new changes to the
email
field to thelogin
attribute as well.
@jhawthorn perhaps you can weigh in here. I’d be happy to prepare a PR once we settle on what we think the behavior should be. I’m just finding it weird to have accounts with this legacy login
field set to whatever the initial value was and not able to be modified later. Let me know what you think!