Skip to content

Commit eae7d24

Browse files
committed
feat: enable MODMESH_USE_PYSIDE to on, by default
refactor: remove the switch refactor: comments refactor: update the comment for the PySide6
1 parent f55469c commit eae7d24

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ endif()
1616
option(BUILD_QT "build with QT" ON)
1717
message(STATUS "BUILD_QT: ${BUILD_QT}")
1818

19+
# PySide6 is required since 2023 (see issue https://github.com/solvcon/modmesh/issues/220)
20+
message(STATUS "PySide6 support: REQUIRED")
21+
1922
option(BUILD_METAL "build with Metal" OFF)
2023
message(STATUS "BUILD_METAL: ${BUILD_METAL}")
2124
if(BUILD_METAL)
@@ -138,6 +141,7 @@ set(MODMESH_INCLUDE_DIR "${CMAKE_CURRENT_LIST_DIR}/cpp" CACHE INTERNAL "")
138141

139142
include_directories(${MODMESH_INCLUDE_DIR})
140143

144+
add_compile_definitions(MODMESH_USE_PYSIDE)
141145
execute_process(
142146
COMMAND python3 -c "import sys, os, PySide6; sys.stdout.write(os.path.dirname(PySide6.__file__))"
143147
OUTPUT_VARIABLE PYSIDE6_PYTHON_PACKAGE_PATH

cpp/modmesh/pilot/wrap_pilot.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#include <QClipboard>
3737
#include <QMenu>
3838

39-
// Usually MODMESH_PYSIDE6_FULL is not defined unless for debugging.
39+
// PySide6 is required since 2023 (see issue https://github.com/solvcon/modmesh/issues/220)
4040
#ifdef MODMESH_PYSIDE6_FULL
4141
#include <pyside.h>
4242
#else // MODMESH_PYSIDE6_FULL

0 commit comments

Comments
 (0)