Improved show ip interface cli performance by listing only interfaces… #4103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wih ip without affecting the exsting behavior
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… wih ip without affecting the exsting behavior
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tested the fix on a testbed ToR and the latency of 'show ip interface' has substantially gone down. Using "ip -o addr show" cmd helps considerably |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kktheballer
approved these changes
Nov 7, 2025
Contributor
kktheballer
left a comment
kktheballer
left a comment
There was a problem hiding this comment.
Tested the PR on a DUT and verified that 'show ip interface' lag was brought down from indefinitely long to 9-13 seconds which is great (tested using a scale of 428 subinterfaces)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved show ip interface cli performance by listing only interfaces with ip, without affecting the existing behavior.
show ip interface was very slow at large scale because the code iterated all kernel netdevices and called netifaces.ifaddresses() per interface—even for L2-only ports without any IPs. With ~5k netdevices, this caused multi-minute runs or forced aborts.
What I did
Changed enumeration to only process interfaces that actually have IP addresses for the selected family.
Avoided per-iface sysfs reads (flags, carrier) unless the iface has at least one IP.
Kept CLI surface/output format and multi-ASIC behavior unchanged.
How I did it
Used ip -o -f inet|inet6 addr show to seed the set of (namespace, interface) that have addresses.
Built the BGP neighbor map as before; enriched rows only for those interfaces.
Read admin/oper/master state only for the filtered set.
Merged per-namespace results the same way as the original implementation.
How to verify it
time show ip interface > /dev/null (compute only)
time show ip interface | head (partial print)
time show ip interface (full print)
Expect ~4–12s depending on scale (previously minutes/aborts).
Previous command output (if the output of a command-line utility has changed)
No change
New command output (if the output of a command-line utility has changed)
No change