Skip to content

Commit fd17871

Browse files
msukkarimsukkari
authored
chore(tech-debt): Remove built-in secret manager (#592)
1 parent 581a5a0 commit fd17871

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+422
-5307
lines changed

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1616
- Fixed "The account is already associated with another user" errors with GitLab oauth provider. [#584](https://github.com/sourcebot-dev/sourcebot/pull/584)
1717
- Fixed error when viewing a generic git connection in `/settings/connections`. [#588](https://github.com/sourcebot-dev/sourcebot/pull/588)
1818

19+
## Removed
20+
- Removed built-in secret manager. [#592](https://github.com/sourcebot-dev/sourcebot/pull/592)
21+
1922
## [4.8.1] - 2025-10-29
2023

2124
### Fixed

‎docs/docs/connections/ado-cloud.mdx‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ If you're not familiar with Sourcebot [connections](/docs/connections/overview),
8686
Azure Devops Cloud requires you to provide a PAT in order to index your repositories. To learn how to create PAT, check out the [Azure Devops docs](https://learn.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=Windows).
8787
Sourcebot needs the `Read` access for the `Code` scope in order to find and clone your repos.
8888

89-
Next, provide the access token via the `token` property, either as an environment variable or a secret:
89+
Next, provide the access token via an environment variable which is referenced in the `token` property:
9090

9191
<Tabs>
9292
<Tab title="Environment Variable">
@@ -113,28 +113,6 @@ Next, provide the access token via the `token` property, either as an environmen
113113
ghcr.io/sourcebot-dev/sourcebot:latest
114114
```
115115
</Tab>
116-
117-
<Tab title="Secret">
118-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
119-
120-
1. Navigate to **Secrets** in settings and create a new secret with your PAT:
121-
122-
![](/images/secrets_list.png)
123-
124-
2. Add the `token` property to your connection config:
125-
126-
```json
127-
{
128-
"type": "azuredevops",
129-
"deploymentType": "cloud",
130-
"token": {
131-
"secret": "mysecret"
132-
}
133-
// .. rest of config ..
134-
}
135-
```
136-
137-
</Tab>
138116
</Tabs>
139117

140118
## Schema reference

‎docs/docs/connections/ado-server.mdx‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ If you're not familiar with Sourcebot [connections](/docs/connections/overview),
100100
Azure Devops Server requires you to provide a PAT in order to index your repositories. To learn how to create PAT, check out the [Azure Devops docs](https://learn.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=Windows).
101101
Sourcebot needs the `Read` access for the `Code` scope in order to find and clone your repos.
102102

103-
Next, provide the access token via the `token` property, either as an environment variable or a secret:
103+
Next, provide the access token via an environment variable which is referenced in the `token` property:
104104

105105
<Tabs>
106106
<Tab title="Environment Variable">
@@ -127,28 +127,6 @@ Next, provide the access token via the `token` property, either as an environmen
127127
ghcr.io/sourcebot-dev/sourcebot:latest
128128
```
129129
</Tab>
130-
131-
<Tab title="Secret">
132-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
133-
134-
1. Navigate to **Secrets** in settings and create a new secret with your PAT:
135-
136-
![](/images/secrets_list.png)
137-
138-
2. Add the `token` property to your connection config:
139-
140-
```json
141-
{
142-
"type": "azuredevops",
143-
"deploymentType": "server",
144-
"token": {
145-
"secret": "mysecret"
146-
}
147-
// .. rest of config ..
148-
}
149-
```
150-
151-
</Tab>
152130
</Tabs>
153131

154132
## Schema reference

‎docs/docs/connections/gitea.mdx‎

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ In order to index private repositories, you'll need to generate a Gitea access t
8181

8282
![Gitea Access token creation](/images/gitea_pat_creation.png)
8383

84-
Next, provide the access token via the `token` property, either as an environment variable or a secret:
84+
Next, provide the access token via an environment variable which is referenced in the `token` property:
8585

8686
<Tabs>
8787
<Tab title="Environment Variable">
@@ -107,27 +107,6 @@ Next, provide the access token via the `token` property, either as an environmen
107107
ghcr.io/sourcebot-dev/sourcebot:latest
108108
```
109109
</Tab>
110-
111-
<Tab title="Secret">
112-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
113-
114-
1. Navigate to **Secrets** in settings and create a new secret with your PAT:
115-
116-
![](/images/secrets_list.png)
117-
118-
2. Add the `token` property to your connection config:
119-
120-
```json
121-
{
122-
"type": "gitea",
123-
"token": {
124-
"secret": "mysecret"
125-
}
126-
// .. rest of config ..
127-
}
128-
```
129-
130-
</Tab>
131110
</Tabs>
132111

133112
## Connecting to a custom Gitea

‎docs/docs/connections/github.mdx‎

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ In order to index private repositories, you'll need to generate a access token a
128128
</Accordion>
129129
</AccordionGroup>
130130

131-
Next, provide the access token via the `token` property, either as an environment variable or a secret:
131+
Next, provide the access token via an environment variable which is referenced in the `token` property:
132132

133133
<Tabs>
134134
<Tab title="Environment Variable">
@@ -154,27 +154,6 @@ Next, provide the access token via the `token` property, either as an environmen
154154
ghcr.io/sourcebot-dev/sourcebot:latest
155155
```
156156
</Tab>
157-
158-
<Tab title="Secret">
159-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
160-
161-
1. Navigate to **Secrets** in settings and create a new secret with your PAT:
162-
163-
![](/images/secrets_list.png)
164-
165-
2. Add the `token` property to your connection config:
166-
167-
```json
168-
{
169-
"type": "github",
170-
"token": {
171-
"secret": "mysecret"
172-
}
173-
// .. rest of config ..
174-
}
175-
```
176-
177-
</Tab>
178157
</Tabs>
179158

180159
## Connecting to a custom GitHub host

‎docs/docs/connections/gitlab.mdx‎

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ In order to index private projects, you'll need to generate a GitLab Personal Ac
116116

117117
![GitLab PAT Scope](/images/gitlab_pat_scopes.png)
118118

119-
Next, provide the PAT via the `token` property, either as an environment variable or a secret:
119+
Next, provide the PAT via an environment variable which is referenced in the `token` property:
120120

121121
<Tabs>
122122
<Tab title="Environment Variable">
@@ -142,27 +142,6 @@ Next, provide the PAT via the `token` property, either as an environment variabl
142142
ghcr.io/sourcebot-dev/sourcebot:latest
143143
```
144144
</Tab>
145-
146-
<Tab title="Secret">
147-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
148-
149-
1. Navigate to **Secrets** in settings and create a new secret with your PAT:
150-
151-
![](/images/secrets_list.png)
152-
153-
2. Add the `token` property to your connection config:
154-
155-
```json
156-
{
157-
"type": "gitlab",
158-
"token": {
159-
"secret": "mysecret"
160-
}
161-
// .. rest of config ..
162-
}
163-
```
164-
165-
</Tab>
166145
</Tabs>
167146

168147
## Connecting to a custom GitLab host

‎docs/snippets/bitbucket-app-password.mdx‎

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -24,27 +24,4 @@
2424
ghcr.io/sourcebot-dev/sourcebot:latest
2525
```
2626
</Tab>
27-
28-
<Tab title="Secret">
29-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
30-
31-
1. Navigate to **Secrets** in settings and create a new secret with your access token:
32-
33-
![](/images/secrets_list.png)
34-
35-
2. Add the `token` and `user` (username associated with the app password you created) properties to your connection config:
36-
37-
```json
38-
{
39-
"type": "bitbucket",
40-
"deploymentType": "cloud",
41-
"user": "myusername",
42-
"token": {
43-
"secret": "mysecret"
44-
}
45-
// .. rest of config ..
46-
}
47-
```
48-
49-
</Tab>
5027
</Tabs>

‎docs/snippets/bitbucket-token.mdx‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,4 @@
2222
ghcr.io/sourcebot-dev/sourcebot:latest
2323
```
2424
</Tab>
25-
26-
<Tab title="Secret">
27-
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>
28-
29-
1. Navigate to **Secrets** in settings and create a new secret with your PAT:
30-
31-
![](/images/secrets_list.png)
32-
33-
2. Add the `token` property to your connection config:
34-
35-
```json
36-
{
37-
"type": "bitbucket",
38-
"token": {
39-
"secret": "mysecret"
40-
}
41-
// .. rest of config ..
42-
}
43-
```
44-
45-
</Tab>
4625
</Tabs>

‎docs/snippets/schemas/v2/index.schema.mdx‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
"token": {
7878
"description": "A Personal Access Token (PAT).",
7979
"examples": [
80-
"secret-token",
8180
{
8281
"env": "ENV_VAR_CONTAINING_TOKEN"
8382
}
@@ -274,7 +273,6 @@
274273
"token": {
275274
"description": "An authentication token.",
276275
"examples": [
277-
"secret-token",
278276
{
279277
"env": "ENV_VAR_CONTAINING_TOKEN"
280278
}
@@ -465,7 +463,6 @@
465463
"token": {
466464
"description": "An access token.",
467465
"examples": [
468-
"secret-token",
469466
{
470467
"env": "ENV_VAR_CONTAINING_TOKEN"
471468
}
@@ -779,7 +776,6 @@
779776
"token": {
780777
"description": "A Personal Access Token (PAT).",
781778
"examples": [
782-
"secret-token",
783779
{
784780
"env": "ENV_VAR_CONTAINING_TOKEN"
785781
}
@@ -976,7 +972,6 @@
976972
"token": {
977973
"description": "An authentication token.",
978974
"examples": [
979-
"secret-token",
980975
{
981976
"env": "ENV_VAR_CONTAINING_TOKEN"
982977
}
@@ -1167,7 +1162,6 @@
11671162
"token": {
11681163
"description": "An access token.",
11691164
"examples": [
1170-
"secret-token",
11711165
{
11721166
"env": "ENV_VAR_CONTAINING_TOKEN"
11731167
}
@@ -1563,7 +1557,6 @@
15631557
"token": {
15641558
"description": "A Personal Access Token (PAT).",
15651559
"examples": [
1566-
"secret-token",
15671560
{
15681561
"env": "ENV_VAR_CONTAINING_TOKEN"
15691562
}
@@ -1760,7 +1753,6 @@
17601753
"token": {
17611754
"description": "An authentication token.",
17621755
"examples": [
1763-
"secret-token",
17641756
{
17651757
"env": "ENV_VAR_CONTAINING_TOKEN"
17661758
}
@@ -1951,7 +1943,6 @@
19511943
"token": {
19521944
"description": "An access token.",
19531945
"examples": [
1954-
"secret-token",
19551946
{
19561947
"env": "ENV_VAR_CONTAINING_TOKEN"
19571948
}

‎docs/snippets/schemas/v3/app.schema.mdx‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,6 @@
2828
"privateKey": {
2929
"description": "The private key of the GitHub App.",
3030
"anyOf": [
31-
{
32-
"type": "object",
33-
"properties": {
34-
"secret": {
35-
"type": "string",
36-
"description": "The name of the secret that contains the token."
37-
}
38-
},
39-
"required": [
40-
"secret"
41-
],
42-
"additionalProperties": false
43-
},
4431
{
4532
"type": "object",
4633
"properties": {
@@ -90,19 +77,6 @@
9077
"privateKey": {
9178
"description": "The private key of the GitHub App.",
9279
"anyOf": [
93-
{
94-
"type": "object",
95-
"properties": {
96-
"secret": {
97-
"type": "string",
98-
"description": "The name of the secret that contains the token."
99-
}
100-
},
101-
"required": [
102-
"secret"
103-
],
104-
"additionalProperties": false
105-
},
10680
{
10781
"type": "object",
10882
"properties": {

0 commit comments

Comments
 (0)