Skip to content

Commit 158d926

Browse files
committed
ux: new style for submodule diff
Signed-off-by: leo <[email protected]>
1 parent 99b7208 commit 158d926

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

src/Views/DiffView.axaml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,11 @@
261261

262262
<ScrollViewer Grid.Row="1" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
263263
<StackPanel Orientation="Vertical" Margin="8,0">
264-
<Border IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNotNull}}">
264+
<Border Height="16" HorizontalAlignment="Center" Background="Red" CornerRadius="8" IsVisible="{Binding New, Converter={x:Static ObjectConverters.IsNull}}">
265+
<TextBlock Classes="primary" Text="{DynamicResource Text.Diff.Submodule.Deleted}" Margin="8,0" FontSize="10" Foreground="White"/>
266+
</Border>
267+
268+
<Border Margin="0,8,0,0" IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNotNull}}">
265269
<ContentControl Content="{Binding Old}">
266270
<ContentControl.DataTemplates>
267271
<DataTemplate DataType="m:RevisionSubmodule">
@@ -273,12 +277,19 @@
273277
</ContentControl>
274278
</Border>
275279

280+
<Path Width="16" Height="16" Data="{StaticResource Icons.DoubleDown}" HorizontalAlignment="Center">
281+
<Path.IsVisible>
282+
<MultiBinding Converter="{x:Static BoolConverters.And}">
283+
<Binding Path="Old" Converter="{x:Static ObjectConverters.IsNotNull}"/>
284+
<Binding Path="New" Converter="{x:Static ObjectConverters.IsNotNull}"/>
285+
</MultiBinding>
286+
</Path.IsVisible>
287+
</Path>
288+
276289
<Border Height="16" HorizontalAlignment="Center" Background="Green" CornerRadius="8" IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNull}}">
277290
<TextBlock Classes="primary" Text="{DynamicResource Text.Diff.Submodule.New}" Margin="8,0" FontSize="10" Foreground="White"/>
278291
</Border>
279292

280-
<Path Width="16" Height="16" Data="{StaticResource Icons.DoubleDown}" HorizontalAlignment="Center" IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNotNull}}"/>
281-
282293
<Border Margin="0,8,0,0" BorderThickness="1" BorderBrush="Green" Background="{DynamicResource Brush.Window}" IsVisible="{Binding New, Converter={x:Static ObjectConverters.IsNotNull}}">
283294
<ContentControl Content="{Binding New}">
284295
<ContentControl.DataTemplates>
@@ -288,10 +299,6 @@
288299
</ContentControl.DataTemplates>
289300
</ContentControl>
290301
</Border>
291-
292-
<Border Margin="0,8,0,0" Height="16" HorizontalAlignment="Center" Background="Red" CornerRadius="8" IsVisible="{Binding New, Converter={x:Static ObjectConverters.IsNull}}">
293-
<TextBlock Classes="primary" Text="{DynamicResource Text.Diff.Submodule.Deleted}" Margin="8,0" FontSize="10" Foreground="White"/>
294-
</Border>
295302
</StackPanel>
296303
</ScrollViewer>
297304
</Grid>

0 commit comments

Comments
 (0)