fix: prevent crash in Custom Action when executable path is missing (#646)

ChiahongHong · web-flow · commit fba84c82978e · 2024-11-03T17:00:17.000+08:00
diff --git a/src/Commands/ExecuteCustomAction.cs b/src/Commands/ExecuteCustomAction.cs
@@ -45,6 +45,9 @@ public static void Run(string repo, string file, string args, Action<string> out
             try
             {
                 proc.Start();
+                proc.BeginOutputReadLine();
+                proc.BeginErrorReadLine();
+                proc.WaitForExit();
             }
             catch (Exception e)
             {
@@ -54,9 +57,6 @@ public static void Run(string repo, string file, string args, Action<string> out
                 });
             }
 
-            proc.BeginOutputReadLine();
-            proc.BeginErrorReadLine();
-            proc.WaitForExit();
             proc.Close();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,9 @@ public static void Run(string repo, string file, string args, Action<string> out`
`45`	`45`	`try`
`46`	`46`	`{`
`47`	`47`	`proc.Start();`
	`48`	`+ proc.BeginOutputReadLine();`
	`49`	`+ proc.BeginErrorReadLine();`
	`50`	`+ proc.WaitForExit();`
`48`	`51`	`}`
`49`	`52`	`catch (Exception e)`
`50`	`53`	`{`
`@@ -54,9 +57,6 @@ public static void Run(string repo, string file, string args, Action<string> out`
`54`	`57`	`});`
`55`	`58`	`}`
`56`	`59`
`57`		`- proc.BeginOutputReadLine();`
`58`		`- proc.BeginErrorReadLine();`
`59`		`- proc.WaitForExit();`
`60`	`60`	`proc.Close();`
`61`	`61`	`}`
`62`	`62`	`}`