codeintel: disable flaky test (#43470)

* codeintel: disable flaky test

* Add explicit flake

Author: sanderginn

dev/ci/go-backcompat/flakefiles/v4.1.0.json

@@ -0,0 +1,7 @@
+[
+  {
+    "path": "internal/codeintel/policies/internal/store",
+    "prefix": "TestSelectPoliciesForRepositoryMembershipUpdate",
+    "reason": "The same policies are returned but in an unexpected order."
+  }
+]

internal/codeintel/policies/internal/store/store_repo_test.go

@@ -199,6 +199,8 @@ func TestUpdateReposMatchingPatternsOverLimit(t *testing.T) {
 }
 
 func TestSelectPoliciesForRepositoryMembershipUpdate(t *testing.T) {
+	t.Skip("Flaky due to unexpected ordering of results: https://github.com/sourcegraph/sourcegraph/issues/43472")
+
 	logger := logtest.Scoped(t)
 	db := database.NewDB(logger, dbtest.NewDB(logger, t))
 	store := testStoreWithoutConfigurationPolicies(t, db)

internal/search/result/result_type.go

@@ -1,6 +1,9 @@
 package result
 
-import "strings"
+import (
+	"sort"
+	"strings"
+)
 
 // Types represents a set of result types.
 // It's a bitset corresponding to the disjunction of types it represents.
@@ -50,5 +53,6 @@ func (r Types) String() string {
 		}
 		names = append(names, name)
 	}
+	sort.Strings(names)
 	return strings.Join(names, "|")
 }