Move enterprise/internal/batches package to internal/batches (#54855) (#54866)

This moves another heavy enterprise component out to the regular
directory.

Author: eseliger

.github/test.CODEOWNERS

@@ -121,7 +121,7 @@
 
 /enterprise/internal/authz/**/* @unknwon
 
-/enterprise/internal/batches/**/* @eseliger
+/internal/batches/**/* @eseliger
 
 /enterprise/internal/cloud/**/* @unknwon @michaellzc
 

cmd/frontend/graphqlbackend/BUILD.bazel

@@ -14,7 +14,7 @@ import (
 	"google.golang.org/grpc/status"
 
 	"github.com/sourcegraph/sourcegraph/internal/api"
-	"github.com/sourcegraph/sourcegraph/internal/batches"
+	"github.com/sourcegraph/sourcegraph/internal/batches/syncer"
 	"github.com/sourcegraph/sourcegraph/internal/codeintel/dependencies"
 	"github.com/sourcegraph/sourcegraph/internal/database"
 	"github.com/sourcegraph/sourcegraph/internal/errcode"
@@ -41,7 +41,7 @@ type Server struct {
 		UpdateOnce(id api.RepoID, name api.RepoName)
 		ScheduleInfo(id api.RepoID) *protocol.RepoUpdateSchedulerInfoResult
 	}
-	ChangesetSyncRegistry batches.ChangesetSyncRegistry
+	ChangesetSyncRegistry syncer.ChangesetSyncRegistry
 	RateLimitSyncer       interface {
 		// SyncRateLimiters should be called when an external service changes so that
 		// our internal rate limiters are kept in sync

cmd/repo-updater/repoupdater/BUILD.bazel

@@ -25,7 +25,7 @@ import (
 	"github.com/sourcegraph/sourcegraph/internal/actor"
 	"github.com/sourcegraph/sourcegraph/internal/api"
 	"github.com/sourcegraph/sourcegraph/internal/authz"
-	"github.com/sourcegraph/sourcegraph/internal/batches"
+	"github.com/sourcegraph/sourcegraph/internal/batches/syncer"
 	"github.com/sourcegraph/sourcegraph/internal/codeintel/dependencies"
 	"github.com/sourcegraph/sourcegraph/internal/conf"
 	"github.com/sourcegraph/sourcegraph/internal/conf/conftypes"
@@ -460,7 +460,7 @@ func watchSyncer(
 	logger log.Logger,
 	syncer *repos.Syncer,
 	sched *repos.UpdateScheduler,
-	changesetSyncer batches.UnarchivedChangesetSyncRegistry,
+	changesetSyncer syncer.UnarchivedChangesetSyncRegistry,
 ) {
 	logger.Debug("started new repo syncer updates scheduler relay thread")
 

cmd/repo-updater/repoupdater/server.go

@@ -10,7 +10,7 @@ how to define them.
 The final result is the definition of a @sourcegraph_back_compat target, whose test targets are exactly
 the same as back then, but with instead a new schema.
 
-Example: `bazel test @sourcegraph_back_compat//enterprise/internal/batches/...`.
+Example: `bazel test @sourcegraph_back_compat//internal/batches/...`.
 
 See https://sourcegraph.com/search?q=context:global+dev/backcompat/patches/back_compat_migrations.patch+repo:github.com/sourcegraph/sourcegraph+lang:Go&patternType=standard&sm=0&groupBy=repo
 for the command generating the mandatory patch file in CI for these tests to run.
@@ -21,7 +21,6 @@ eventuality of someone running those locally).
 
 load("test_release_version.bzl", "MINIMUM_UPGRADEABLE_VERSION", "MINIMUM_UPGRADEABLE_VERSION_REF")
 load("flakes.bzl", "FLAKES")
-
 load("@bazel_gazelle//:deps.bzl", "go_repository")
 load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 
@@ -100,8 +99,8 @@ def back_compat_defs():
         ],
         build_file_proto_mode = "disable_global",
         importpath = "github.com/sourcegraph/scip",
-        sum = "h1:fWPxLkDObzzKTGe9vb6wpzK0FYkwcfSxmxUBvAOc8aw=", # Need to be manually updated when bumping the back compat release target.
-        version = "v0.2.4-0.20221213205653-aa0e511dcfef", # Need to be manually updated when bumping the back compat release target.
+        sum = "h1:fWPxLkDObzzKTGe9vb6wpzK0FYkwcfSxmxUBvAOc8aw=",  # Need to be manually updated when bumping the back compat release target.
+        version = "v0.2.4-0.20221213205653-aa0e511dcfef",  # Need to be manually updated when bumping the back compat release target.
     )
 
     # Same logic for this repository.
@@ -110,13 +109,13 @@ def back_compat_defs():
         build_directives = [
             "gazelle:resolve go github.com/sourcegraph/sourcegraph/lib/errors @sourcegraph_back_compat//lib/errors",
         ],
-        build_file_proto_mode = "disable_global", importpath =
-        "github.com/sourcegraph/conc",
-        sum = "h1:96VpOCAtXDCQ8Oycz0ftHqdPyMi8w12ltN4L2noYg7s=", # Need to be manually updated when bumping the back compat release target.
-        version = "v0.2.0", # Need to be manually updated when bumping the back compat release target.
+        build_file_proto_mode = "disable_global",
+        importpath =
+            "github.com/sourcegraph/conc",
+        sum = "h1:96VpOCAtXDCQ8Oycz0ftHqdPyMi8w12ltN4L2noYg7s=",  # Need to be manually updated when bumping the back compat release target.
+        version = "v0.2.0",  # Need to be manually updated when bumping the back compat release target.
     )
 
-
     # Now that we have declared a replacement for the two problematic go packages that
     # @sourcegraph_back_compat depends on, we can define the repository itself. Because it
     # comes with its Bazel rules (logical, that's just the current repository but with a different

cmd/repo-updater/shared/BUILD.bazel

@@ -16,7 +16,7 @@ coverage:
           - cmd/frontend/graphqlbackend/batches.go
           - internal/usagestats/batches.go
           - enterprise/cmd/frontend/internal/batches
-          - enterprise/internal/batches
+          - internal/batches
           - client/web/src/enterprise/batches
       insights:
         informational: true

cmd/repo-updater/shared/main.go

@@ -7,7 +7,7 @@ They are defined in the [`goroutine`](https://sourcegraph.com/github.com/sourceg
 Examples:
 
 - [`worker.NewWorker`](https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+worker.NewWorker&patternType=literal), for example, produces a background routine, which in this case is a background worker.
-- [`batches.newSpecExpireWorker`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/enterprise/internal/batches/background/spec_expire.go?subtree=true#L13-27) returns a [`goroutine.PeriodicGoroutine`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@b946a20362ee7dfedb3b1fbc7f8bb002135d7283/-/blob/internal/goroutine/periodic.go?subtree=true#L14:78), which means it's invoked periodically.
+- [`batches.newSpecExpireWorker`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/internal/batches/background/spec_expire.go?subtree=true#L13-27) returns a [`goroutine.PeriodicGoroutine`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@b946a20362ee7dfedb3b1fbc7f8bb002135d7283/-/blob/internal/goroutine/periodic.go?subtree=true#L14:78), which means it's invoked periodically.
 - [out-of-band migrations](oobmigrations.md) are implemented as background routines.
 - [`HardDeleter`](https://sourcegraph.com/github.com/sourcegraph/sourcegraph@b946a20362ee7dfedb3b1fbc7f8bb002135d7283/-/blob/enterprise/cmd/frontend/internal/codeintel/background/janitor/hard_delete.go?subtree=true#L33) is a periodic background routine that periodically hard-deletes soft-deleted upload records.