Skip to content

Commit 348c80b

Browse files
committed
address code review comments
1 parent 6f63ec1 commit 348c80b

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

tests/searchcommands/chunked_data_stream.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,12 @@ def __init__(self, stream):
3939

4040
def read_chunk(self):
4141
header = self.stream.readline()
42-
if len(header) == 0:
43-
raise EOFError
4442

4543
while len(header) > 0 and header.strip() == b'':
4644
header = self.stream.readline() # Skip empty lines
45+
46+
if len(header) == 0:
47+
raise EOFError
4748
version, meta, data = header.rstrip().split(b',')
4849
metabytes = self.stream.read(int(meta))
4950
databytes = self.stream.read(int(data))
@@ -82,22 +83,13 @@ def _build_data_csv(data):
8283
return b''
8384
if isinstance(data, bytes):
8485
return data
85-
if six.PY2:
86-
csvout = io.BytesIO()
87-
else:
88-
csvout = io.StringIO()
86+
csvout = splunklib.six.StringIO()
8987

9088
headers = set()
9189
for datum in data:
92-
if six.PY2:
93-
headers.update(datum.keys())
94-
else:
95-
headers.update(datum.keys())
90+
headers.update(datum.keys())
9691
writer = csv.DictWriter(csvout, headers, dialect=splunklib.searchcommands.internals.CsvDialect)
9792
writer.writeheader()
9893
for datum in data:
99-
if six.PY2:
100-
writer.writerow(datum)
101-
else:
102-
writer.writerow(datum)
94+
writer.writerow(datum)
10395
return six.ensure_binary(csvout.getvalue())

0 commit comments

Comments
 (0)