Skip to content

Commit a865779

Browse files
committed
Fiddle around with CI/CD #7
1 parent e51e42f commit a865779

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

.github/workflows/release.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,21 @@ on:
55

66
jobs:
77
publish:
8-
name: Deploy Release to PyPI
8+
name: Deploy release to PyPI
99
runs-on: ubuntu-latest
1010
steps:
11-
- name: Checkout source
11+
- name: Checkout source code
1212
uses: actions/checkout@v3
1313
- name: Set up Python
1414
uses: actions/setup-python@v4
1515
with:
1616
python-version: 3.9
1717
- name: Install dependencies
1818
run: pip install .
19+
# [BJ] Shouldn't we run tests here to prevent an easily preventable catastrophe?
20+
# Or is test.yml being ran when we publish a package?
1921
- name: Build package
22+
# [TODO] We need to confirm this produces the same exact result as `python setup.py sdist`
2023
run: python -m build
2124
- name: Publish package to PyPI
2225
uses: pypa/[email protected]
@@ -27,7 +30,7 @@ jobs:
2730
run: |
2831
rm -rf ./docs/_build
2932
tox -e docs
30-
- name: Docs Upload
33+
- name: Upload docs
3134
uses: actions/upload-artifact@v3
3235
with:
3336
name: python_sdk_docs
@@ -37,5 +40,5 @@ jobs:
3740
# uses: pypa/gh-action-pypi-publish@master
3841
# with:
3942
# user: __token__
40-
# password: ${{ secrets.test_pypi_password }}
43+
# password: ${{ secrets.TEST_PYPI_PASSWORD }}
4144
# repository_url: https://test.pypi.org/legacy/

.github/workflows/test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
fail-fast: false
2828

2929
steps:
30-
- name: Checkout code
30+
- name: Checkout source code
3131
uses: actions/checkout@v3
3232
- name: Set up .env
3333
run: cp ./.env.template ./.env
@@ -41,7 +41,7 @@ jobs:
4141
run: pip install .
4242
- name: Run test suite
4343
run: tox -e py
44-
45-
# fossa-scan:
46-
# uses: splunk/oss-scanning-public/.github/workflows/oss-scan.yml@main
47-
# secrets: inherit
44+
# [BJ] I'll obviously uncomment this step after I finish fiddling
45+
# fossa-scan:
46+
# uses: splunk/oss-scanning-public/.github/workflows/oss-scan.yml@main
47+
# secrets: inherit

0 commit comments

Comments
 (0)