Skip to content

Commit 284725f

Browse files
committed
Polish "Expose Stackdriver's useSemanticMetricTypes property"
See gh-28403
1 parent 9397121 commit 284725f

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/stackdriver/StackdriverProperties.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,9 @@ public class StackdriverProperties extends StepRegistryProperties {
4848
private Map<String, String> resourceLabels;
4949

5050
/**
51-
* Whether to use semantically correct metric types. When this is false, counter
52-
* metrics are published as the GAUGE MetricKind. When this is true, counter metrics
53-
* are published as the CUMULATIVE MetricKind. This is false by default for the sake
54-
* of backwards compatibility.
51+
* Whether to use semantically correct metric types. When false, counter metrics are
52+
* published as the GAUGE MetricKind. When true, counter metrics are published as the
53+
* CUMULATIVE MetricKind.
5554
*/
5655
private boolean useSemanticMetricTypes = false;
5756

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/stackdriver/StackdriverPropertiesConfigAdapterTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ void whenPropertiesUseSemanticMetricTypesIsSetAdapterResourceTypeReturnsIt() {
6060
StackdriverProperties properties = new StackdriverProperties();
6161
properties.setUseSemanticMetricTypes(true);
6262
assertThat(new StackdriverPropertiesConfigAdapter(properties).useSemanticMetricTypes()).isTrue();
63-
properties.setUseSemanticMetricTypes(false);
64-
assertThat(new StackdriverPropertiesConfigAdapter(properties).useSemanticMetricTypes()).isFalse();
6563
}
6664

6765
}

0 commit comments

Comments
 (0)