Update Couchbase Java SDK to 3.10.0 - #2107
Merged
Merged
Conversation
onobc
suggested changes
Dec 3, 2025
onobc
left a comment
There was a problem hiding this comment.
Hi @emilienbev,
Looks good. A couple of minor comments:
- Can you update the commit message to reference the issue that it closes (see here).
You did mention the issue in the commit message summary but if you add it at the end w/ "Closes " prefix then it will auto close when the PR is merged.
For this commit it would look like:
Update Couchbase Java SDK to 3.10.0
Closes #2106
- In something this simple you can just create a PR instead of an issue and a PR (first item here).
Thanks,
Chris
Closes #2106 Signed-off-by: Emilien Bevierre <44171454+emilienbev@users.noreply.github.com>
emilienbev
force-pushed
the
Couchbase3.10.0Upgrade
branch
from
December 4, 2025 09:39
f91b8fc to
8f8a9ae
Compare
Collaborator
Author
|
Thanks for the review @onobc. Noted, next time I'll just make the PR without a ticket. |
onobc
approved these changes
Dec 8, 2025
onobc
left a comment
There was a problem hiding this comment.
Thanks for the updates @emilienbev - LGTM. Feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2106