Skip to content

Update Couchbase Java SDK to 3.10.0 - #2107

Merged
emilienbev merged 1 commit into
mainfrom
Couchbase3.10.0Upgrade
Dec 8, 2025
Merged

emilienbev merged 1 commit into
mainfrom
Couchbase3.10.0Upgrade

Conversation

@emilienbev

@emilienbev emilienbev commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator

Resolves #2106

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 3, 2025

@onobc onobc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @emilienbev,

Looks good. A couple of minor comments:

  1. Can you update the commit message to reference the issue that it closes (see here).
    You did mention the issue in the commit message summary but if you add it at the end w/ "Closes " prefix then it will auto close when the PR is merged.

For this commit it would look like:

Update Couchbase Java SDK to 3.10.0

Closes #2106
  1. In something this simple you can just create a PR instead of an issue and a PR (first item here).

Thanks,
Chris

@onobc onobc changed the title #2106 - Update Couchbase Java SDK to 3.10.0 Update Couchbase Java SDK to 3.10.0 Dec 3, 2025
@onobc onobc added status: feedback-provided Feedback has been provided and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 3, 2025
Closes #2106

Signed-off-by: Emilien Bevierre <44171454+emilienbev@users.noreply.github.com>
@emilienbev
emilienbev force-pushed the Couchbase3.10.0Upgrade branch from f91b8fc to 8f8a9ae Compare December 4, 2025 09:39
@emilienbev

Copy link
Copy Markdown
Collaborator Author

Thanks for the review @onobc.

Noted, next time I'll just make the PR without a ticket.
I rewrote the commit message to include Closes #2106, it should be good to go now?

@onobc onobc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @emilienbev - LGTM. Feel free to merge.

@emilienbev
emilienbev merged commit 0997e1f into main Dec 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: feedback-provided Feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Couchbase Java SDK to 3.10.0

3 participants