Polishing

Closes gh-34372

Author: sdeleuze

spring-context/src/main/java/org/springframework/context/support/DefaultLifecycleProcessor.java

@@ -714,14 +714,8 @@ public void checkpointRestore() {
 	 */
 	private class CracResourceAdapter implements org.crac.Resource {
 
-		private CyclicBarrier stepToRestore = new CyclicBarrier(2);
-		private CyclicBarrier finishRestore = new CyclicBarrier(2);
-
-		private void preventShutdown() {
-			waitBarrier(this.stepToRestore);
-			// Checkpoint happens here
-			waitBarrier(this.finishRestore);
-		}
+		private final CyclicBarrier beforeCheckpointBarrier = new CyclicBarrier(2);
+		private final CyclicBarrier afterRestoreBarrier = new CyclicBarrier(2);
 
 		@Override
 		public void beforeCheckpoint(org.crac.Context<? extends org.crac.Resource> context) {
@@ -733,39 +727,35 @@ public void beforeCheckpoint(org.crac.Context<? extends org.crac.Resource> conte
 			stopForRestart();
 		}
 
+		private void preventShutdown() {
+			awaitBarrier(this.beforeCheckpointBarrier);
+			// Checkpoint happens here
+			awaitBarrier(this.afterRestoreBarrier);
+		}
+
 		@Override
 		public void afterRestore(org.crac.Context<? extends org.crac.Resource> context) {
 			// Unlock barrier for beforeCheckpoint
-			try {
-				this.stepToRestore.await();
-			}
-			catch (Exception ex) {
-				logger.trace("Exception from stepToRestore barrier", ex);
-			}
+			awaitBarrier(this.beforeCheckpointBarrier);
 
 			logger.info("Restarting Spring-managed lifecycle beans after JVM restore");
 			restartAfterStop();
 
 			// Unlock barrier for afterRestore to shutdown "prevent-shutdown" thread
-			try {
-				this.finishRestore.await();
-			}
-			catch (Exception ex) {
-				logger.trace("Exception from stepToRestore barrier", ex);
-			}
+			awaitBarrier(this.afterRestoreBarrier);
 
 			if (!checkpointOnRefresh) {
 				logger.info("Spring-managed lifecycle restart completed (restored JVM running for " +
 						CRaCMXBean.getCRaCMXBean().getUptimeSinceRestore() + " ms)");
 			}
 		}
 
-		private void waitBarrier(CyclicBarrier barrier) {
+		private void awaitBarrier(CyclicBarrier barrier) {
 			try {
 				barrier.await();
 			}
 			catch (Exception ex) {
-				logger.trace("Exception from prevent-shutdown barrier", ex);
+				logger.trace("Exception from barrier", ex);
 			}
 		}
 	}