Skip to content

Commit 59f470b

Browse files
therepaniconobc
authored andcommitted
clean up all possible deprecations
Closes: gh-232 Signed-off-by: Andrey Litvitski <[email protected]>
1 parent 1193647 commit 59f470b

File tree

4 files changed

+20
-16
lines changed

4 files changed

+20
-16
lines changed

spring-grpc-core/src/main/java/org/springframework/grpc/server/security/HttpBasicConfigurer.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,14 @@ public HttpBasicConfigurer<H> userDetailsService(UserDetailsService userDetailsS
4343

4444
@Override
4545
public void configure(H builder) throws Exception {
46-
DaoAuthenticationProvider provider = new DaoAuthenticationProvider();
4746
UserDetailsService userDetailsService = this.userDetailsService;
4847
if (userDetailsService == null) {
4948
userDetailsService = this.authenticationManagerBuilder.getDefaultUserDetailsService();
5049
}
5150
if (userDetailsService == null) {
5251
userDetailsService = this.context.getBean(UserDetailsService.class);
5352
}
54-
provider.setUserDetailsService(userDetailsService);
53+
DaoAuthenticationProvider provider = new DaoAuthenticationProvider(userDetailsService);
5554
this.authenticationManagerBuilder.authenticationProvider(provider);
5655
}
5756

spring-grpc-core/src/main/java/org/springframework/grpc/server/security/OAuth2ResourceServerConfigurer.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,10 @@ public OpaqueTokenConfigurer authenticationManager(AuthenticationManager authent
186186
public OpaqueTokenConfigurer introspectionUri(String introspectionUri) {
187187
Assert.notNull(introspectionUri, "introspectionUri cannot be null");
188188
this.introspectionUri = introspectionUri;
189-
this.introspector = () -> new SpringOpaqueTokenIntrospector(this.introspectionUri, this.clientId,
190-
this.clientSecret);
189+
this.introspector = () -> SpringOpaqueTokenIntrospector.withIntrospectionUri(this.introspectionUri)
190+
.clientId(this.clientId)
191+
.clientSecret(this.clientSecret)
192+
.build();
191193
return this;
192194
}
193195

@@ -196,8 +198,10 @@ public OpaqueTokenConfigurer introspectionClientCredentials(String clientId, Str
196198
Assert.notNull(clientSecret, "clientSecret cannot be null");
197199
this.clientId = clientId;
198200
this.clientSecret = clientSecret;
199-
this.introspector = () -> new SpringOpaqueTokenIntrospector(this.introspectionUri, this.clientId,
200-
this.clientSecret);
201+
this.introspector = () -> SpringOpaqueTokenIntrospector.withIntrospectionUri(this.introspectionUri)
202+
.clientId(this.clientId)
203+
.clientSecret(this.clientSecret)
204+
.build();
201205
return this;
202206
}
203207

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/security/OAuth2ClientAutoConfiguration.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,11 @@
2121
import org.springframework.boot.autoconfigure.AutoConfiguration;
2222
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2323
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
24-
import org.springframework.boot.autoconfigure.security.oauth2.client.ClientsConfiguredCondition;
24+
import org.springframework.boot.autoconfigure.security.oauth2.client.ConditionalOnOAuth2ClientRegistrationProperties;
2525
import org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientProperties;
2626
import org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesMapper;
2727
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2828
import org.springframework.context.annotation.Bean;
29-
import org.springframework.context.annotation.Conditional;
3029
import org.springframework.context.annotation.Configuration;
3130
import org.springframework.security.oauth2.client.registration.ClientRegistration;
3231
import org.springframework.security.oauth2.client.registration.ClientRegistrationRepository;
@@ -35,10 +34,10 @@
3534
// Copied from Spring Boot (https://github.com/spring-projects/spring-boot/issues/40997, ]
3635
// https://github.com/spring-projects/spring-boot/issues/15877)
3736
@AutoConfiguration(
38-
after = org.springframework.boot.autoconfigure.security.oauth2.client.servlet.OAuth2ClientAutoConfiguration.class)
37+
after = org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientAutoConfiguration.class)
3938
@Configuration(proxyBeanMethods = false)
4039
@ConditionalOnClass(InMemoryClientRegistrationRepository.class)
41-
@Conditional(ClientsConfiguredCondition.class)
40+
@ConditionalOnOAuth2ClientRegistrationProperties
4241
@EnableConfigurationProperties(OAuth2ClientProperties.class)
4342
public class OAuth2ClientAutoConfiguration {
4443

spring-grpc-spring-boot-autoconfigure/src/main/java/org/springframework/grpc/autoconfigure/server/security/OAuth2ResourceServerAutoConfiguration.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@
3434
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
3535
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
3636
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
37-
import org.springframework.boot.autoconfigure.security.oauth2.resource.IssuerUriCondition;
38-
import org.springframework.boot.autoconfigure.security.oauth2.resource.KeyValueCondition;
3937
import org.springframework.boot.autoconfigure.security.oauth2.resource.OAuth2ResourceServerProperties;
38+
import org.springframework.boot.autoconfigure.security.oauth2.resource.ConditionalOnIssuerLocationJwtDecoder;
39+
import org.springframework.boot.autoconfigure.security.oauth2.resource.ConditionalOnPublicKeyJwtDecoder;
4040
import org.springframework.boot.autoconfigure.security.oauth2.resource.servlet.JwkSetUriJwtDecoderBuilderCustomizer;
4141
import org.springframework.boot.autoconfigure.security.servlet.SecurityAutoConfiguration;
4242
import org.springframework.boot.autoconfigure.security.servlet.UserDetailsServiceAutoConfiguration;
@@ -119,8 +119,10 @@ static class OpaqueTokenIntrospectionClientConfiguration {
119119
@ConditionalOnProperty(name = "spring.security.oauth2.resourceserver.opaquetoken.introspection-uri")
120120
SpringOpaqueTokenIntrospector blockingOpaqueTokenIntrospector(OAuth2ResourceServerProperties properties) {
121121
OAuth2ResourceServerProperties.Opaquetoken opaqueToken = properties.getOpaquetoken();
122-
return new SpringOpaqueTokenIntrospector(opaqueToken.getIntrospectionUri(), opaqueToken.getClientId(),
123-
opaqueToken.getClientSecret());
122+
return SpringOpaqueTokenIntrospector.withIntrospectionUri(opaqueToken.getIntrospectionUri())
123+
.clientId(opaqueToken.getClientId())
124+
.clientSecret(opaqueToken.getClientSecret())
125+
.build();
124126
}
125127

126128
}
@@ -203,7 +205,7 @@ private boolean nullSafeDisjoint(List<String> c1, List<String> c2) {
203205
}
204206

205207
@Bean
206-
@Conditional(KeyValueCondition.class)
208+
@ConditionalOnPublicKeyJwtDecoder
207209
JwtDecoder blockingJwtDecoderByPublicKeyValue() throws Exception {
208210
RSAPublicKey publicKey = (RSAPublicKey) KeyFactory.getInstance("RSA")
209211
.generatePublic(new X509EncodedKeySpec(getKeySpec(this.properties.readPublicKey())));
@@ -231,7 +233,7 @@ private String exactlyOneAlgorithm() {
231233
}
232234

233235
@Bean
234-
@Conditional(IssuerUriCondition.class)
236+
@ConditionalOnIssuerLocationJwtDecoder
235237
SupplierJwtDecoder blockingJwtDecoderByIssuerUri(
236238
ObjectProvider<JwkSetUriJwtDecoderBuilderCustomizer> customizers) {
237239
return new SupplierJwtDecoder(() -> {

0 commit comments

Comments
 (0)