Skip to content

Commit d891e7a

Browse files
committed
Simplify ci-pr.yml running of samples
See #300 Signed-off-by: onobc <[email protected]>
1 parent 42d230a commit d891e7a

File tree

1 file changed

+11
-39
lines changed

1 file changed

+11
-39
lines changed

.github/workflows/ci-pr.yml

Lines changed: 11 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -12,55 +12,27 @@ jobs:
1212
build_and_verify:
1313
name: Build and Verify
1414
if: ${{ github.repository == 'spring-projects/spring-grpc' }}
15+
strategy:
16+
matrix:
17+
include:
18+
- javaVersion: 25
19+
distribution: 'liberica'
1520
runs-on: ubuntu-latest
1621
steps:
1722
- uses: actions/checkout@v4
18-
- name: Set up JDK 25
23+
- name: Set up Java ${{ matrix.javaVersion }} ${{ matrix.distribution }}
1924
uses: actions/setup-java@v4
2025
with:
21-
java-version: '25'
22-
distribution: 'liberica'
26+
java-version: ${{ matrix.javaVersion }}
27+
distribution: ${{ matrix.distribution }}
2328
cache: maven
24-
- name: Build, test, and run samples using Java 25 w/ target=17
29+
- name: Build, test, and run samples (Java ${{ matrix.javaVersion }} ${{ matrix.distribution }})
2530
run: |
2631
./mvnw -B clean install
27-
28-
- name: Set up JDK 17
29-
uses: actions/setup-java@v4
30-
with:
31-
java-version: '17'
32-
distribution: 'temurin'
33-
cache: maven
34-
- name: Run samples built w/ Java 25 w/ target=17 using Java 17
35-
run: |
36-
pushd samples > /dev/null
37-
../mvnw test \
38-
-Dmaven-checkstyle-plugin.config.location=../src/checkstyle
39-
popd > /dev/null
40-
41-
- name: Set up JDK 25
42-
uses: actions/setup-java@v4
43-
with:
44-
java-version: '25'
45-
distribution: 'liberica'
46-
cache: maven
47-
- name: Build and run samples using Java 25 w/ target=25
48-
run: |
49-
pushd samples > /dev/null
50-
../mvnw clean install \
51-
-pl '!grpc-server-kotlin' \
52-
-Dmaven-checkstyle-plugin.config.location=../src/checkstyle \
53-
-Djava.version=25
54-
../mvnw clean install \
55-
-pl 'grpc-server-kotlin' \
56-
-Dmaven-checkstyle-plugin.config.location=../src/checkstyle \
57-
-Djava.version=24
58-
popd > /dev/null
59-
60-
- name: Capture Test Results
32+
- name: Upload Build Reports (Java ${{ matrix.javaVersion }} ${{ matrix.distribution }})
6133
if: failure()
6234
uses: actions/upload-artifact@v4
6335
with:
64-
name: test-results
36+
name: test-results-java-${{ matrix.javaVersion }}-${{ matrix.distribution }}
6537
path: '*/target/surefire-reports/*.*'
6638
retention-days: 3

0 commit comments

Comments
 (0)