Skip to content

Use final fields in equals and hashCode of PathPatternRequestMatcher #17584

@codingtim

Description

@codingtim

The equals and hashCode implementation of PathPatternRequestMatcher was altered in
#17337

The current implementation of PathPatternRequestMatcher has a non-final field RequestMatcher method.
A setter is present for this field and is used in the Builder.

It seems like a bad practice to use non-final fields inside the equals and hashCode implementation.

I suggest improving this: codingtim@2b5df1c

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)status: duplicateA duplicate of another issuetype: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions