Skip to content

Commit 0dd0338

Browse files
Rename AggregateAs() -> SelectAggregate().
1 parent 6b5fd57 commit 0dd0338

File tree

6 files changed

+101
-101
lines changed

6 files changed

+101
-101
lines changed

QueryBuilder.Tests/AggregateTests.cs

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ namespace SqlKata.Tests
88
public class AggregateTests : TestSupport
99
{
1010
[Fact]
11-
public void AggregateAsEmpty()
11+
public void SelectAggregateEmpty()
1212
{
13-
Assert.Throws<ArgumentException>(() => new Query("A").AggregateAs("aggregate", new string[] { }));
13+
Assert.Throws<ArgumentException>(() => new Query("A").SelectAggregate("aggregate", new string[] { }));
1414
}
1515

1616
[Fact]
17-
public void AggregateAs()
17+
public void SelectAggregate()
1818
{
19-
var query = new Query("A").AggregateAs("aggregate", new[] { "Column" });
19+
var query = new Query("A").SelectAggregate("aggregate", new[] { "Column" });
2020

2121
var c = Compile(query);
2222

@@ -27,9 +27,9 @@ public void AggregateAs()
2727
}
2828

2929
[Fact]
30-
public void AggregateAsAlias()
30+
public void SelectAggregateAlias()
3131
{
32-
var query = new Query("A").AggregateAs("aggregate", new[] { "Column" }, "Alias");
32+
var query = new Query("A").SelectAggregate("aggregate", new[] { "Column" }, "Alias");
3333

3434
var c = Compile(query);
3535

@@ -40,9 +40,9 @@ public void AggregateAsAlias()
4040
}
4141

4242
[Fact]
43-
public void AggregateAsMultipleColumns()
43+
public void SelectAggregateMultipleColumns()
4444
{
45-
var query = new Query("A").AggregateAs("aggregate", new[] { "Column1", "Column2" });
45+
var query = new Query("A").SelectAggregate("aggregate", new[] { "Column1", "Column2" });
4646

4747
var c = Compile(query);
4848

@@ -53,9 +53,9 @@ public void AggregateAsMultipleColumns()
5353
}
5454

5555
[Fact]
56-
public void AggregateAsMultipleColumnsAlias()
56+
public void SelectAggregateMultipleColumnsAlias()
5757
{
58-
var query = new Query("A").AggregateAs("aggregate", new[] { "Column1", "Column2" }, "Alias");
58+
var query = new Query("A").SelectAggregate("aggregate", new[] { "Column1", "Column2" }, "Alias");
5959

6060
var c = Compile(query);
6161

@@ -66,9 +66,9 @@ public void AggregateAsMultipleColumnsAlias()
6666
}
6767

6868
[Fact]
69-
public void CountAs()
69+
public void SelectCount()
7070
{
71-
var query = new Query("A").CountAs();
71+
var query = new Query("A").SelectCount();
7272

7373
var c = Compile(query);
7474

@@ -79,9 +79,9 @@ public void CountAs()
7979
}
8080

8181
[Fact]
82-
public void CountAsStarAlias()
82+
public void SelectCountStarAlias()
8383
{
84-
var query = new Query("A").CountAs("*", "Alias");
84+
var query = new Query("A").SelectCount("*", "Alias");
8585

8686
var c = Compile(query);
8787

@@ -92,9 +92,9 @@ public void CountAsStarAlias()
9292
}
9393

9494
[Fact]
95-
public void CountAsColumnAlias()
95+
public void SelectCountColumnAlias()
9696
{
97-
var query = new Query("A").CountAs("Column", "Alias");
97+
var query = new Query("A").SelectCount("Column", "Alias");
9898

9999
var c = Compile(query);
100100

@@ -105,17 +105,17 @@ public void CountAsColumnAlias()
105105
}
106106

107107
[Fact]
108-
public void CountAsDoesntModifyColumns()
108+
public void SelectCountDoesntModifyColumns()
109109
{
110110
{
111111
var columns = new string[] { };
112-
var query = new Query("A").CountAs(columns);
112+
var query = new Query("A").SelectCount(columns);
113113
Compile(query);
114114
Assert.Equal(columns, new string[] { });
115115
}
116116
{
117117
var columns = new[] { "ColumnA", "ColumnB" };
118-
var query = new Query("A").CountAs(columns);
118+
var query = new Query("A").SelectCount(columns);
119119
Compile(query);
120120
Assert.Equal(columns, new[] { "ColumnA", "ColumnB" });
121121
}
@@ -124,17 +124,17 @@ public void CountAsDoesntModifyColumns()
124124
[Fact]
125125
public void CountMultipleColumns()
126126
{
127-
var query = new Query("A").CountAs(new[] { "ColumnA", "ColumnB" });
127+
var query = new Query("A").SelectCount(new[] { "ColumnA", "ColumnB" });
128128

129129
var c = Compile(query);
130130

131131
Assert.Equal("SELECT COUNT(*) AS [count] FROM (SELECT 1 FROM [A] WHERE [ColumnA] IS NOT NULL AND [ColumnB] IS NOT NULL) AS [CountQuery]", c[EngineCodes.SqlServer]);
132132
}
133133

134134
[Fact]
135-
public void CountAsMultipleColumns()
135+
public void SelectCountMultipleColumns()
136136
{
137-
var query = new Query("A").CountAs(new[] { "ColumnA", "ColumnB" }, "Alias");
137+
var query = new Query("A").SelectCount(new[] { "ColumnA", "ColumnB" }, "Alias");
138138

139139
var c = Compile(query);
140140

@@ -144,7 +144,7 @@ public void CountAsMultipleColumns()
144144
[Fact]
145145
public void DistinctCount()
146146
{
147-
var query = new Query("A").Distinct().CountAs();
147+
var query = new Query("A").Distinct().SelectCount();
148148

149149
var c = Compile(query);
150150

@@ -154,7 +154,7 @@ public void DistinctCount()
154154
[Fact]
155155
public void DistinctCountMultipleColumns()
156156
{
157-
var query = new Query("A").Distinct().CountAs(new[] { "ColumnA", "ColumnB" });
157+
var query = new Query("A").Distinct().SelectCount(new[] { "ColumnA", "ColumnB" });
158158

159159
var c = Compile(query);
160160

@@ -164,7 +164,7 @@ public void DistinctCountMultipleColumns()
164164
[Fact]
165165
public void Average()
166166
{
167-
var query = new Query("A").AverageAs("TTL");
167+
var query = new Query("A").SelectAverage("TTL");
168168

169169
var c = Compile(query);
170170

@@ -174,7 +174,7 @@ public void Average()
174174
[Fact]
175175
public void AverageAlias()
176176
{
177-
var query = new Query("A").AverageAs("TTL", "Alias");
177+
var query = new Query("A").SelectAverage("TTL", "Alias");
178178

179179
var c = Compile(query);
180180

@@ -184,7 +184,7 @@ public void AverageAlias()
184184
[Fact]
185185
public void Sum()
186186
{
187-
var query = new Query("A").SumAs("PacketsDropped");
187+
var query = new Query("A").SelectSum("PacketsDropped");
188188

189189
var c = Compile(query);
190190

@@ -194,7 +194,7 @@ public void Sum()
194194
[Fact]
195195
public void SumAlias()
196196
{
197-
var query = new Query("A").SumAs("PacketsDropped", "Alias");
197+
var query = new Query("A").SelectSum("PacketsDropped", "Alias");
198198

199199
var c = Compile(query);
200200

@@ -204,7 +204,7 @@ public void SumAlias()
204204
[Fact]
205205
public void Max()
206206
{
207-
var query = new Query("A").MaxAs("LatencyMs");
207+
var query = new Query("A").SelectMax("LatencyMs");
208208

209209
var c = Compile(query);
210210

@@ -214,7 +214,7 @@ public void Max()
214214
[Fact]
215215
public void MaxAlias()
216216
{
217-
var query = new Query("A").MaxAs("LatencyMs", "Alias");
217+
var query = new Query("A").SelectMax("LatencyMs", "Alias");
218218

219219
var c = Compile(query);
220220

@@ -224,7 +224,7 @@ public void MaxAlias()
224224
[Fact]
225225
public void Min()
226226
{
227-
var query = new Query("A").MinAs("LatencyMs");
227+
var query = new Query("A").SelectMin("LatencyMs");
228228

229229
var c = Compile(query);
230230

@@ -234,7 +234,7 @@ public void Min()
234234
[Fact]
235235
public void MinAlias()
236236
{
237-
var query = new Query("A").MinAs("LatencyMs", "Alias");
237+
var query = new Query("A").SelectMin("LatencyMs", "Alias");
238238

239239
var c = Compile(query);
240240

QueryBuilder.Tests/DefineTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public void Test_Define_SubQuery()
2929
{
3030

3131
var subquery = new Query("Products")
32-
.AverageAs("unitprice")
32+
.SelectAverage("unitprice")
3333
.Define("@UnitsInSt", 10)
3434
.Where("UnitsInStock", ">", Variable("@UnitsInSt"));
3535

@@ -252,7 +252,7 @@ public void Test_Define_NestedCondition()
252252
.Where(q =>
253253
q.Where("ShipRegion", "!=", Variable("@shipReg"))
254254
// .WhereRaw("1 = @one")
255-
).CountAs();
255+
).SelectCount();
256256

257257
var c = Compile(query);
258258

QueryBuilder.Tests/SelectTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public void OrWhereNull()
192192
[Fact]
193193
public void WhereSub()
194194
{
195-
var subQuery = new Query("Table2").WhereColumns("Table2.Column", "=", "Table.MyCol").CountAs();
195+
var subQuery = new Query("Table2").WhereColumns("Table2.Column", "=", "Table.MyCol").SelectCount();
196196

197197
var query = new Query("Table").WhereSub(subQuery, 1);
198198

@@ -206,7 +206,7 @@ public void WhereSub()
206206
[Fact]
207207
public void OrWhereSub()
208208
{
209-
var subQuery = new Query("Table2").WhereColumns("Table2.Column", "=", "Table.MyCol").CountAs();
209+
var subQuery = new Query("Table2").WhereColumns("Table2.Column", "=", "Table.MyCol").SelectCount();
210210

211211
var query = new Query("Table").WhereNull("MyCol").OrWhereSub(subQuery, "<", 1);
212212

QueryBuilder/Query.Aggregate.cs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ public partial class Query
88
/**********************************************************************
99
** Generic aggregate **
1010
**********************************************************************/
11-
public Query AggregateAs(string type, IEnumerable<string> columns, string alias = null)
11+
public Query SelectAggregate(string type, IEnumerable<string> columns, string alias = null)
1212
{
1313
if (columns.Count() == 0)
1414
{
@@ -32,55 +32,55 @@ public Query AggregateAs(string type, IEnumerable<string> columns, string alias
3232
/**********************************************************************
3333
** Count **
3434
**********************************************************************/
35-
public Query CountAs(string column = null, string alias = null)
35+
public Query SelectCount(string column = null, string alias = null)
3636
{
37-
return CountAs(column != null ? new[] { column } : new string[] { }, alias);
37+
return SelectCount(column != null ? new[] { column } : new string[] { }, alias);
3838
}
3939

40-
public Query CountAs(IEnumerable<string> columns, string alias = null)
40+
public Query SelectCount(IEnumerable<string> columns, string alias = null)
4141
{
42-
return AggregateAs("count", columns.Count() == 0 ? new[] { "*" } : columns, alias);
42+
return SelectAggregate("count", columns.Count() == 0 ? new[] { "*" } : columns, alias);
4343
}
4444

4545

4646
/**********************************************************************
4747
** Average **
4848
**********************************************************************/
49-
public Query AvgAs(string column, string alias = null)
49+
public Query SelectAvg(string column, string alias = null)
5050
{
51-
return AggregateAs("avg", new[] { column }, alias);
51+
return SelectAggregate("avg", new[] { column }, alias);
5252
}
5353

54-
public Query AverageAs(string column, string alias = null)
54+
public Query SelectAverage(string column, string alias = null)
5555
{
56-
return AvgAs(column, alias);
56+
return SelectAvg(column, alias);
5757
}
5858

5959

6060
/**********************************************************************
6161
** Sum **
6262
**********************************************************************/
63-
public Query SumAs(string column, string alias = null)
63+
public Query SelectSum(string column, string alias = null)
6464
{
65-
return AggregateAs("sum", new[] { column }, alias);
65+
return SelectAggregate("sum", new[] { column }, alias);
6666
}
6767

6868

6969
/**********************************************************************
7070
** Maximum **
7171
**********************************************************************/
72-
public Query MaxAs(string column, string alias = null)
72+
public Query SelectMax(string column, string alias = null)
7373
{
74-
return AggregateAs("max", new[] { column }, alias);
74+
return SelectAggregate("max", new[] { column }, alias);
7575
}
7676

7777

7878
/**********************************************************************
7979
** Minimum **
8080
**********************************************************************/
81-
public Query MinAs(string column, string alias = null)
81+
public Query SelectMin(string column, string alias = null)
8282
{
83-
return AggregateAs("min", new[] { column }, alias);
83+
return SelectAggregate("min", new[] { column }, alias);
8484
}
8585
}
8686
}

0 commit comments

Comments
 (0)