Skip to content

Remove unused globalSourceRanges from Encoder via MethodMassage #157

Description

@LinqLover

Quoting from the version message of Compiler-eem.504:

globalSourceRanges appears to be unused. It has been removed from the code, but cannot be removed from Encoder because class shape changes do not recompile code atomically and so the specific BytecodeEncoder subclass is broken when attempting to recompile itself without the globalSourceRanges inst var. The fix would be to use bytecode scanning to revise methods when class shapes change (a la VisualWorks).

With the recent introduction of MethodMassage into the trunk, this should be easier to be done now. The result of this ticket would be a Monticello version that removes the instance variable via a preamble script, deprecates the accessor, and formally undeclares the variable from the class definition as a regular monticello operation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    base system[SCOPE] Squeak's basic (language) concerns such as Kernel, Collections, Graphics, Networkdebt[WHAT] The issue represents technical or design debt, pointing to code smells etc.good first issue :-)[RATING] Good for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions