fix Build with newer .NET 10 SDKs (#1772)

* fix Build with newer .NET 10 SDKs

The IDE0370 are a mess since they only affect certain target frameworks.
Maybe we should disable this one completely instead?

Also set a fixed SDK Version in CI so this doesn't randomly break again.

* Remove IDE0370

* global.json: use latestMinor

to make sure that dotnet-setup installs the
exact version, see #1772 (comment)

* Update global.json

Co-authored-by: Rob Hague <rob.hague00@gmail.com>

---------

Co-authored-by: Rob Hague <rob.hague00@gmail.com>

Author: mus65

.editorconfig

@@ -847,6 +847,11 @@ dotnet_diagnostic.IDE0300.severity = none
 # TODO: Discuss whether we want to start using this
 dotnet_diagnostic.IDE0301.severity = none
 
+# IDE0370: Remove unnecessary suppression
+#
+# This can lead to many false positives in different target frameworks.
+dotnet_diagnostic.IDE0370.severity = suggestion
+
 #### .NET Compiler Platform code style rules ####
 
 ### Language rules ###

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "10.0.100",
-    "rollForward": "latestFeature"
+    "version": "10.0.201",
+    "rollForward": "latestMinor"
   }
 }

src/Renci.SshNet/ForwardedPort.cs

@@ -105,10 +105,7 @@ protected virtual void StopPort(TimeSpan timeout)
             RaiseClosing();
 
             var session = Session;
-            if (session is not null)
-            {
-                session.ErrorOccured -= Session_ErrorOccurred;
-            }
+            session?.ErrorOccured -= Session_ErrorOccurred;
         }
 
         /// <summary>

src/Renci.SshNet/OrderedDictionary.netstandard.cs

@@ -234,7 +234,7 @@ public bool Remove(TKey key, [MaybeNullWhen(false)] out TValue value)
             }
 
             AssertConsistency();
-            value = default!;
+            value = default;
             return false;
         }
 

test/Renci.SshNet.Tests/Classes/AbstractionsTest.cs

@@ -1,5 +1,7 @@
-using Renci.SshNet.Abstractions;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+using Renci.SshNet.Abstractions;
+
 using System;
 using System.Threading;
 using System.Security.Cryptography;