Add stgit.new.verbose config option

Instead of piggybacking on Git's commit.new config option, StGit now has
its own config option for turning-on `stg new --verbose`.

Two considerations for this change:

- `stg new` does not refresh, thus it leaves changes in the worktree.
  This is a significant semantic difference with `git commit` that makes
  reuse of `commit.verbose` an awkward fit.

- The performance implications in large monorepos with `stg new
  --verbose` versus `git commit --verbose` are quite different. See
  #145. The gist is that the diff operation needed for `stg new
  --verbose` can be much more expensive than `git commit --verbose`.

Signed-off-by: Peter Grayson <[email protected]>

Author: jpgrayson

CHANGELOG.md

@@ -14,7 +14,7 @@
 - `stg edit` gains helpful instructions (#138)
 - `stg new` learns `--verbose`, which includes a diff in the editor
   window (similar to `git commit --verbose`). This behavior is also
-  configurable with the `commit.verbose` configuration option
+  configurable with the `stgit.new.verbose` configuration option
 - `stg push` and `stg float` learn `--noapply` option; allows patches
   to be reordered without updating worktree and deferring merge conflict
   resolution (#144)

stgit/commands/new.py

@@ -87,7 +87,7 @@ def func(parser, options, args):
     if options.verbose:
         verbose = options.verbose
     else:
-        verbose = config.getbool('commit.verbose') or False
+        verbose = config.getbool('stgit.new.verbose') or False
 
     cd = CommitData(
         tree=stack.head.data.tree,

t/t1003-new.sh

@@ -114,7 +114,7 @@ test_expect_success \
     'New with verbose config option' '
     test_set_editor "$(pwd)/fake-editor" &&
     test_when_finished test_set_editor false &&
-    test_config commit.verbose "1" &&
+    test_config stgit.new.verbose "1" &&
     stg new verbose-config-patch &&
     grep "something else" raw_commit_message.txt
 '
@@ -123,7 +123,7 @@ test_expect_success \
     'New with verbose config boolean option' '
     test_set_editor "$(pwd)/fake-editor" &&
     test_when_finished test_set_editor false &&
-    test_config commit.verbose "true" &&
+    test_config stgit.new.verbose "true" &&
     stg new verbose-config-bool-patch &&
     grep "something else" raw_commit_message.txt
 '