Fix linter issues

Author: Alex-Welsh

.github/workflows/stackhpc-pull-request.yml

@@ -100,6 +100,8 @@ jobs:
       - name: Linting code 🧪
         run: |
           ansible-lint -v --force-color etc/kayobe/ansible/.
+        env:
+          KAYOBE_CONFIG_PATH: ${{ github.workspace }}/etc/kayobe/
 
   # A skipped job is treated as success when used as a required status check.
   # The registered required status checks refer to the name of the job in the

doc/source/configuration/wazuh.rst

@@ -252,7 +252,7 @@ vault file which will be placed in ``$KAYOBE_CONFIG_PATH/deployment/wazuh-secret
 If using environments it ends up in ``$KAYOBE_CONFIG_PATH/environments/<env_name>/deployment/wazuh-secrets.yml``
 Remember to encrypt!
 
-Wazuh secrets template is located in ``$KAYOBE_CONFIG_PATH/ansible/templates/deployment/wazuh-secrets.yml.j2``.
+Wazuh secrets template is located in ``$KAYOBE_CONFIG_PATH/ansible/templates/wazuh-secrets.yml.j2``.
 It will be used by wazuh secrets playbook to generate wazuh secrets vault file.
 
 

etc/kayobe/ansible/deployment/deploy-os-capacity-exporter.yml

@@ -48,7 +48,7 @@
 
         - name: Template clouds.yml
           ansible.builtin.template:
-            src: templates/os_capacity-clouds.yml.j2
+            src: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/ansible/templates/os_capacity-clouds.yml.j2"
             dest: /opt/kayobe/os-capacity/clouds.yaml
           register: clouds_yaml_result
 

etc/kayobe/ansible/deployment/smartmon-tools.yml

@@ -56,7 +56,7 @@
 
     - name: Copy smartmon.py and nvmemon.sh from scripts folder
       ansible.builtin.copy:
-        src: scripts/{{ item }}
+        src: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/ansible/scripts/{{ item }}"
         dest: /usr/local/bin/{{ item }}
         owner: root
         group: root

etc/kayobe/ansible/deployment/wazuh-secrets.yml

@@ -19,7 +19,7 @@
     - name: Template new secrets
       no_log: true
       ansible.builtin.template:
-        src: wazuh-secrets.yml.j2
+        src: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/ansible/templates/wazuh-secrets.yml.j2"
         dest: "{{ wazuh_secrets_path }}"
 
     - name: In-place encrypt wazuh-secrets

etc/kayobe/ansible/deployment/write-github-workflows.yml

@@ -2,6 +2,6 @@
 - name: Write Kayobe Automation Workflows for GitHub
   hosts: github-writer
   vars:
-    github_output_directory: "{{ kayobe_config_path }}/../../.github/workflows"
+    github_output_directory: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/../../.github/workflows"
   roles:
     - stackhpc.kayobe_workflows.github

etc/kayobe/ansible/deployment/write-gitlab-pipelines.yml

@@ -2,6 +2,6 @@
 - name: Write Kayobe Automation Pipeline for GitLab
   hosts: gitlab-writer
   vars:
-    gitlab_output_directory: "{{ kayobe_config_path }}/../../"
+    gitlab_output_directory: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/../../"
   roles:
     - stackhpc.kayobe_workflows.gitlab

etc/kayobe/ansible/fixes/fix-hostname.yml

@@ -23,7 +23,7 @@
       become: true
 
 - name: Reboot hosts
-  import_playbook: "{{ playbook_dir | realpath }}/maintenance/reboot.yml"
+  import_playbook: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/ansible/maintenance/reboot.yml"
   vars:
     reboot_hosts: fix-hostname
     reboot_with_bootstrap_user: true

etc/kayobe/ansible/fixes/fix-houston.yml

@@ -23,7 +23,7 @@
 
     - name: Create systemd service for -ovs network interface
       ansible.builtin.template:
-        src: fix-houston-interface.service.j2
+        src: "{{ lookup('env', 'KAYOBE_CONFIG_PATH') }}/ansible/templates/fix-houston-interface.service.j2"
         dest: /etc/systemd/system/fix-houston-{{ item }}.service
       loop: "{{ neutron_bridge_name.split(',') }}"
       vars:

etc/kayobe/ansible/maintenance/octavia-amphora-image-register.yml

@@ -12,7 +12,7 @@
         lookup('env', 'OS_PROJECT_NAME') != 'service'
 
 - name: Download Amphora image from Ark
-  ansible.builtin.import_playbook: pulp-amphora-image-download.yml
+  ansible.builtin.import_playbook: ../pulp/pulp-amphora-image-download.yml
   when: download_amphora_from_ark | bool
 
 - name: Register an Octavia Amphora image in Glance