Skip to content

docs: remove default_branch from config.yaml #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stackhpc/2025.1
Choose a base branch
from

Conversation

jackhodgkiss
Copy link
Contributor

By setting the default_branch the generation of release notes fails to capture all of the tags releases within a given branch.

By setting the `default_branch` the generation of release notes fails to
capture all of the tags releases within a given branch.
@Alex-Welsh
Copy link
Member

This was required to get zuul CI to work #1791

Do you know any other way we could get this to work?

@jackhodgkiss
Copy link
Contributor Author

This was required to get zuul CI to work #1791

Do you know any other way we could get this to work?

What is Zuul doing that means the configuration for release notes requires default branch set?

@Alex-Welsh
Copy link
Member

This was required to get zuul CI to work #1791
Do you know any other way we could get this to work?

What is Zuul doing that means the configuration for release notes requires default branch set?

It runs a pep8 job which isn't really pep8, it's more just a release notes check. For some reason it succeeds in GH CI but fails in zuul https://zuul.stackhpc.com/t/stackhpc/build/54c03714f1f2432ea7db98c1900e641b

@jackhodgkiss
Copy link
Contributor Author

This was required to get zuul CI to work #1791
Do you know any other way we could get this to work?

What is Zuul doing that means the configuration for release notes requires default branch set?

It runs a pep8 job which isn't really pep8, it's more just a release notes check. For some reason it succeeds in GH CI but fails in zuul https://zuul.stackhpc.com/t/stackhpc/build/54c03714f1f2432ea7db98c1900e641b

It is because the repository is cloned with --bare this causes the error ValueError: Unknown reference 'master'

The docs for reno say that --branch can be provided however this doesn't work for reno lint. In fact --branch appears on all but reno lint. https://static.opendev.org/docs/reno/2.3.0/usage.html#configuring-reno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants