Rename method to be more clear

marickvantuil · marickvantuil · commit f4421b5a3cb3 · 2020-12-06T19:14:29.000+01:00
diff --git a/src/OpenIdVerificator.php b/src/OpenIdVerificator.php
@@ -53,7 +53,7 @@ public function getPublicKey($kid = null)
         if (Cache::has(self::V3_CERTS)) {
             $v3Certs = Cache::get(self::V3_CERTS);
         } else {
-            $v3Certs = $this->getv3Certs();
+            $v3Certs = $this->getFreshCertificates();
             Cache::put(self::V3_CERTS, $v3Certs, Carbon::now()->addSeconds($this->maxAge[self::URL_OPENID_CONFIG]));
         }
 
@@ -62,7 +62,7 @@ public function getPublicKey($kid = null)
         return $this->extractPublicKeyFromCertificate($cert);
     }
 
-    private function getv3Certs()
+    private function getFreshCertificates()
     {
         $jwksUri =  $this->callApiAndReturnValue(self::URL_OPENID_CONFIG, 'jwks_uri');
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function getPublicKey($kid = null)`
`53`	`53`	`if (Cache::has(self::V3_CERTS)) {`
`54`	`54`	`$v3Certs = Cache::get(self::V3_CERTS);`
`55`	`55`	`} else {`
`56`		`- $v3Certs = $this->getv3Certs();`
	`56`	`+ $v3Certs = $this->getFreshCertificates();`
`57`	`57`	`Cache::put(self::V3_CERTS, $v3Certs, Carbon::now()->addSeconds($this->maxAge[self::URL_OPENID_CONFIG]));`
`58`	`58`	`}`
`59`	`59`
`@@ -62,7 +62,7 @@ public function getPublicKey($kid = null)`
`62`	`62`	`return $this->extractPublicKeyFromCertificate($cert);`
`63`	`63`	`}`
`64`	`64`
`65`		`- private function getv3Certs()`
	`65`	`+ private function getFreshCertificates()`
`66`	`66`	`{`
`67`	`67`	`$jwksUri = $this->callApiAndReturnValue(self::URL_OPENID_CONFIG, 'jwks_uri');`
`68`	`68`