Auto-generated commit

Author: stdlib-bot

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 <section class="release" id="unreleased">
 
-## Unreleased (2025-09-18)
+## Unreleased (2025-09-19)
 
 <section class="bug-fixes">
 
@@ -22,6 +22,7 @@
 
 <details>
 
+-   [`29bbe63`](https://github.com/stdlib-js/stdlib/commit/29bbe6352ed375283da50d7363cc537b72736765) - **refactor:** allow non-string dtypes and delegate to `ndarray/base/assign` for copying ndarray views _(by Athan Reines)_
 -   [`ab2e77b`](https://github.com/stdlib-js/stdlib/commit/ab2e77bb82f0c6e7854e3279429a1ec8c6ff5603) - **docs:** update type _(by Athan Reines)_
 -   [`c4cc264`](https://github.com/stdlib-js/stdlib/commit/c4cc264996ce9f4241476c857c4c985fb6612c84) - **docs:** update markup _(by Athan Reines)_
 -   [`77867ac`](https://github.com/stdlib-js/stdlib/commit/77867ac1767a186023f633dea30ddf860962aaed) - **docs:** remove trailing whitespace _(by Philipp Burckhardt)_

dist/index.js

@@ -20,8 +20,11 @@
 
 // MODULES //
 
+var isEqualDataType = require( '@stdlib/ndarray-base-assert-is-equal-data-type' );
 var bufferCtors = require( '@stdlib/ndarray-base-buffer-ctors' );
 var allocUnsafe = require( '@stdlib/buffer-alloc-unsafe' );
+var resolveGetter = require( '@stdlib/array-base-resolve-getter' );
+var resolveSetter = require( '@stdlib/array-base-resolve-setter' );
 
 
 // MAIN //
@@ -32,34 +35,40 @@ var allocUnsafe = require( '@stdlib/buffer-alloc-unsafe' );
 * @private
 * @param {(Array|TypedArray|Buffer)} buffer - input buffer
 * @param {NonNegativeInteger} len - number of elements to cast
-* @param {string} dtype - data type
+* @param {*} dtype - data type
 * @returns {(Array|TypedArray|Buffer)} output buffer
 *
 * @example
 * var b = castBuffer( [ 1.0, 2.0, 3.0 ], 3, 'float64' );
 * // returns <Float64Array>[ 1.0, 2.0, 3.0 ]
 */
 function castBuffer( buffer, len, dtype ) {
+	var bget;
+	var oset;
 	var ctor;
 	var out;
 	var i;
 
-	ctor = bufferCtors( dtype );
-	if ( dtype === 'generic' ) {
+	bget = resolveGetter( buffer );
+	if ( isEqualDataType( dtype, 'generic' ) ) {
 		out = [];
 		for ( i = 0; i < len; i++ ) {
-			out.push( buffer[ i ] );
+			out.push( bget( buffer, i ) );
 		}
-	} else if ( dtype === 'binary' ) {
+		return out;
+	}
+	if ( isEqualDataType( dtype, 'binary' ) ) {
 		out = allocUnsafe( len );
 		for ( i = 0; i < len; i++ ) {
-			out[ i ] = buffer[ i ];
-		}
-	} else {
-		out = new ctor( len );
-		for ( i = 0; i < len; i++ ) {
-			out[ i ] = buffer[ i ]; // TODO: wrap and use accessors here and above
+			out[ i ] = bget( buffer, i );
 		}
+		return out;
+	}
+	ctor = bufferCtors( dtype );
+	out = new ctor( len );
+	oset = resolveSetter( out );
+	for ( i = 0; i < len; i++ ) {
+		oset( out, i, bget( buffer, i ) );
 	}
 	return out;
 }