Skip to content

HardwareTimer: set callback before enabling interrupt #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2019
Merged

HardwareTimer: set callback before enabling interrupt #835

merged 1 commit into from
Dec 16, 2019

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Dec 16, 2019 •
edited by fpistm
Loading

Summary
HardwareTimer: set callback before enabling interrupt to avoid race condition.

Takes into account race condition remark from #806

@fpistm fpistm self-requested a review December 16, 2019 13:48
@fpistm fpistm added this to the 1.8.0🎄 🎅 milestone Dec 16, 2019
@fpistm fpistm added the fix 🩹 Bug fix label Dec 16, 2019
@fpistm fpistm merged commit d2ebcd5 into stm32duino:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
fix 🩹 Bug fix
Projects
None yet
Milestone
1.8.0🎄 🎅
Development

Successfully merging this pull request may close these issues.
2 participants
@ABOSTM @fpistm