Skip to content

Commit c109288

Browse files
committed
fixup! ✨(frontend) adds f2 shortcut using a fakenode since it's outside the treeview struct
1 parent cf8e1d5 commit c109288

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export const DocSubPageItem = (props: TreeViewNodeProps<Doc>) => {
9696
const ariaLabel = docTitle;
9797
const isDisabled = !!doc.deleted_at;
9898
const actionsRef = useRef<HTMLDivElement>(null);
99-
const buttonOptionRef = useRef<HTMLButtonElement | null>(null);
99+
const buttonOptionRef = useRef<HTMLDivElement | null>(null);
100100

101101
const handleKeyDown = (e: React.KeyboardEvent) => {
102102
// F2: focus first action button

src/frontend/apps/impress/src/features/docs/doc-tree/components/DocTree.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const DocTree = ({ currentDoc }: DocTreeProps) => {
3737
treeContext?.treeData.selectedNode?.id === treeContext.root.id;
3838
const rootItemRef = useRef<HTMLDivElement>(null);
3939
const rootActionsRef = useRef<HTMLDivElement>(null);
40-
const rootButtonOptionRef = useRef<HTMLButtonElement | null>(null);
40+
const rootButtonOptionRef = useRef<HTMLDivElement | null>(null);
4141

4242
const { t } = useTranslation();
4343

src/frontend/apps/impress/src/features/docs/doc-tree/components/DocTreeItemActions.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type DocTreeItemActionsProps = {
3333
onOpenChange?: (isOpen: boolean) => void;
3434
parentId?: string | null;
3535
actionsRef?: React.RefObject<HTMLDivElement | null>;
36-
buttonOptionRef?: React.RefObject<HTMLButtonElement | null>;
36+
buttonOptionRef?: React.RefObject<HTMLDivElement | null>;
3737
};
3838

3939
export const DocTreeItemActions = ({
@@ -48,7 +48,7 @@ export const DocTreeItemActions = ({
4848
}: DocTreeItemActionsProps) => {
4949
const internalActionsRef = useRef<HTMLDivElement | null>(null);
5050
const targetActionsRef = actionsRef ?? internalActionsRef;
51-
const internalButtonRef = useRef<HTMLButtonElement | null>(null);
51+
const internalButtonRef = useRef<HTMLDivElement | null>(null);
5252
const targetButtonRef = buttonOptionRef ?? internalButtonRef;
5353
const router = useRouter();
5454
const { t } = useTranslation();
@@ -187,10 +187,8 @@ export const DocTreeItemActions = ({
187187
isOpen={isOpen}
188188
onOpenChange={onOpenChange}
189189
>
190-
<Box
191-
as="button"
190+
<BoxButton
192191
ref={targetButtonRef}
193-
type="button"
194192
onClick={(e) => {
195193
e.stopPropagation();
196194
e.preventDefault();
@@ -220,7 +218,7 @@ export const DocTreeItemActions = ({
220218
$theme="brand"
221219
$variation="secondary"
222220
/>
223-
</Box>
221+
</BoxButton>
224222
</DropdownMenu>
225223
{doc.abilities.children_create && (
226224
<BoxButton

0 commit comments

Comments
 (0)