File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -76,7 +76,11 @@ def create_branch
7676def update_gems
7777 gemfile = File . read ( 'Gemfile' )
7878 included_gems = %w[ cocina-models dor-services-client sdr-client dor_indexing ] . filter { |gem_name | gemfile . include? ( gem_name ) }
79- ErrorEmittingExecutor . execute ( "bundle update --conservative #{ included_gems . join ( ' ' ) } " ) unless included_gems . empty?
79+ # NOTE: --conservative flag can be too aggressive in avoiding updates to dependencies of OUR gems
80+ # e.g. diff-lcs is a tertiary dependency of dor-services-client, so dsc would not be updated
81+ # ErrorEmittingExecutor.execute("bundle update --conservative #{included_gems.join(' ')}") unless included_gems.empty?
82+ # NOTE: NOT using --conservative flag can mean gems we don't want to update get updated (e.g. rails)
83+ ErrorEmittingExecutor . execute ( "bundle update #{ included_gems . join ( ' ' ) } " ) unless included_gems . empty?
8084end
8185
8286# must be called as part of the block for within_cloned_repo_dir(repo)
You can’t perform that action at this time.
0 commit comments