feat(test): run after-create SQL script during extension upgrade tests

Validates that an after-create SQL script can be executed after each extension create/update operation.

Author: jfroche

nix/ext/tests/lib.py

@@ -5,7 +5,7 @@
 installation, upgrades, and version verification of PostgreSQL extensions.
 """
 
-from typing import Sequence, Mapping
+from typing import Sequence, Mapping, Optional
 from pathlib import Path
 from test_driver.machine import Machine
 
@@ -41,7 +41,7 @@ def run_sql(self, query: str) -> str:
             f"""sudo -u postgres psql -t -A -F\",\" -c \"{query}\" """
         ).strip()
 
-    def run_sql_file(self, file: str) -> str:
+    def run_sql_file(self, file: str | Path) -> str:
         return self.vm.succeed(
             f"""sudo -u postgres psql -v ON_ERROR_STOP=1 -f \"{file}\""""
         ).strip()
@@ -88,7 +88,9 @@ def assert_version_matches(self, expected_version: str):
             installed_version == expected_version
         ), f"Expected version {expected_version}, but found {installed_version}"
 
-    def check_upgrade_path(self, pg_version: str):
+    def check_upgrade_path(
+        self, pg_version: str, after_create_script: Optional[Path] = None
+    ):
         """Test the complete upgrade path for a PostgreSQL version.
 
         This method tests all available extension versions for a given PostgreSQL
@@ -113,13 +115,18 @@ def check_upgrade_path(self, pg_version: str):
         self.drop_extension()
         self.install_extension(first_version)
 
+        if after_create_script:
+            self.run_sql_file(after_create_script)
+
         # Test remaining versions
         for version in available_versions[1:]:
             if self.support_upgrade:
                 self.update_extension(version)
             else:
                 self.drop_extension()
                 self.install_extension(version)
+            if after_create_script:
+                self.run_sql_file(after_create_script)
 
     def check_install_last_version(self, pg_version: str) -> str:
         """Test if the install of the last version of the extension works for a given PostgreSQL version.

nix/ext/tests/pgmq.nix

@@ -114,6 +114,7 @@ self.inputs.nixpkgs.lib.nixos.runTest {
       }
       sql_test_directory = Path("${../../tests}")
       pg_regress_test_name = "${(installedExtension "15").pgRegressTestName or pname}"
+      after_create_sql = Path("${../../../ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql}")
 
       ${builtins.readFile ./lib.py}
 
@@ -125,16 +126,15 @@ self.inputs.nixpkgs.lib.nixos.runTest {
       test = PostgresExtensionTest(server, extension_name, versions, sql_test_directory, support_upgrade)
 
       with subtest("Check upgrade path with postgresql 15"):
-        test.check_upgrade_path("15")
-        test.run_sql_file("${../../../ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql}")
+        test.check_upgrade_path("15", after_create_sql)
 
       with subtest("Check pg_regress with postgresql 15 after extension upgrade"):
         test.check_pg_regress(Path("${psql_15}/lib/pgxs/src/test/regress/pg_regress"), "15", pg_regress_test_name)
 
       last_version = None
       with subtest("Check the install of the last version of the extension"):
         last_version = test.check_install_last_version("15")
-        test.run_sql_file("${../../../ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql}")
+        test.run_sql_file(after_create_sql)
 
       if ext_has_background_worker:
         with subtest("Test switch_${pname}_version"):
@@ -150,18 +150,17 @@ self.inputs.nixpkgs.lib.nixos.runTest {
 
       with subtest("Check last version of the extension after postgresql upgrade"):
         test.assert_version_matches(last_version)
-        test.run_sql_file("${../../../ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql}")
+        test.run_sql_file(after_create_sql)
 
       with subtest("Check upgrade path with postgresql 17"):
-        test.check_upgrade_path("17")
-        test.run_sql_file("${../../../ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql}")
+        test.check_upgrade_path("17", after_create_sql)
 
       with subtest("Check pg_regress with postgresql 17 after extension upgrade"):
         test.check_pg_regress(Path("${psql_17}/lib/pgxs/src/test/regress/pg_regress"), "17", pg_regress_test_name)
 
       with subtest("Check the install of the last version of the extension"):
         test.check_install_last_version("17")
-        test.run_sql_file("${../../../ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql}")
+        test.run_sql_file(after_create_sql)
 
       with subtest("Check pg_regress with postgresql 17 after installing the last version"):
         test.check_pg_regress(Path("${psql_17}/lib/pgxs/src/test/regress/pg_regress"), "17", pg_regress_test_name)