chore(ext): document exceptions to generic extension tests

jfroche · jfroche · commit 1a9394d2df31 · 2025-11-10T12:02:14.000+01:00
This helps us identify why certain extensions do not use the generic tests.
diff --git a/nix/ext/tests/http.nix b/nix/ext/tests/http.nix
@@ -154,3 +154,6 @@ self.inputs.nixpkgs.lib.nixos.runTest {
       check_upgrade_path("17")
     '';
 }
+# We don't use the generic test for this extension because:
+# http is not using semver versioning scheme, so we need to adapt the version checks
+# otherwise the test fails with ERROR:  extension "http" has no installation script nor update path for version "1.5.0"
diff --git a/nix/ext/tests/pg_repack.nix b/nix/ext/tests/pg_repack.nix
@@ -160,3 +160,6 @@ self.inputs.nixpkgs.lib.nixos.runTest {
         test.check_upgrade_path("17")
     '';
 }
+# We don't use the generic test for this extension because:
+# pg_repack does not support upgrade as the extension doesn't provide the upgrade SQL scripts
+# and fails with ERROR:  extension "pg_repack" has no update path from version "1.4.8" to version "1.5.0"
diff --git a/nix/ext/tests/pgrouting.nix b/nix/ext/tests/pgrouting.nix
@@ -226,3 +226,4 @@ self.inputs.nixpkgs.lib.nixos.runTest {
       check_upgrade_path("orioledb-17")
     '';
 }
+# We don't use the generic test for this extension because: it requires postgis to be installed as well.

Original file line number	Diff line number	Diff line change
`@@ -154,3 +154,6 @@ self.inputs.nixpkgs.lib.nixos.runTest {`
`154`	`154`	`check_upgrade_path("17")`
`155`	`155`	`'';`
`156`	`156`	`}`
	`157`	`+# We don't use the generic test for this extension because:`
	`158`	`+# http is not using semver versioning scheme, so we need to adapt the version checks`
	`159`	`+# otherwise the test fails with ERROR: extension "http" has no installation script nor update path for version "1.5.0"`
Original file line number	Diff line number	Diff line change
`@@ -160,3 +160,6 @@ self.inputs.nixpkgs.lib.nixos.runTest {`
`160`	`160`	`test.check_upgrade_path("17")`
`161`	`161`	`'';`
`162`	`162`	`}`
	`163`	`+# We don't use the generic test for this extension because:`
	`164`	`+# pg_repack does not support upgrade as the extension doesn't provide the upgrade SQL scripts`
	`165`	`+# and fails with ERROR: extension "pg_repack" has no update path from version "1.4.8" to version "1.5.0"`
Original file line number	Diff line number	Diff line change
`@@ -226,3 +226,4 @@ self.inputs.nixpkgs.lib.nixos.runTest {`
`226`	`226`	`check_upgrade_path("orioledb-17")`
`227`	`227`	`'';`
`228`	`228`	`}`
	`229`	`+# We don't use the generic test for this extension because: it requires postgis to be installed as well.`