Skip to content

Commit 63b9123

Browse files
authored
Adding a note for linking a PR to an issue via a keyword (#960)
1 parent 177e2bc commit 63b9123

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

asciidoc/github_workflow_best_practices.adoc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,4 +246,9 @@ This will open an editor where you can squash, fixup, reword, etc., commits
246246
$ git push --force-with-lease origin myawesomebranch
247247
----
248248

249-
NOTE: See https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History[the official Git documentation for more information]
249+
[NOTE]
250+
====
251+
See https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History[the official Git documentation for more information]
252+
253+
If you're trying to fix a Github issue, don't forget to link the PR to an issue by adding "Closes #XXX" or "Fixes #XXX" to the commit message. See https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword[Linking a pull request to an issue using a keyword] for more information about this feature.
254+
====

0 commit comments

Comments
 (0)