Skip to content

Commit 0d357fd

Browse files
committed
Fix tests after avoiding duplicate ref names.
1 parent a581374 commit 0d357fd

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

modules/swagger-parser/src/test/java/io/swagger/parser/SwaggerParserTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,9 @@ public void testLoadExternalNestedDefinitions() throws Exception {
220220
assertTrue(definitions.containsKey("x"));
221221
assertTrue(definitions.containsKey("y"));
222222
assertTrue(definitions.containsKey("z"));
223-
assertEquals(((RefModel) definitions.get("i")).get$ref(), "#/definitions/k");
223+
assertEquals("#/definitions/k_2", ((RefModel) definitions.get("i")).get$ref());
224+
assertEquals("k-definition", definitions.get("k").getTitle());
225+
assertEquals("k-definition", definitions.get("k_2").getTitle());
224226
}
225227

226228
@Test
@@ -613,7 +615,7 @@ private Swagger doRelativeFileTest(String location) {
613615

614616
assertEquals(composedCat.getInterfaces().size(), 2);
615617
assertEquals(composedCat.getInterfaces().get(0).get$ref(), "#/definitions/pet");
616-
assertEquals(composedCat.getInterfaces().get(1).get$ref(), "#/definitions/foo");
618+
assertEquals(composedCat.getInterfaces().get(1).get$ref(), "#/definitions/foo_2");
617619

618620
return swagger;
619621
}

modules/swagger-parser/src/test/java/io/swagger/parser/processors/ExternalRefProcessorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ public void testProcessRefToExternalDefinition_NoNameConflict(
3636
final RefFormat refFormat = RefFormat.URL;
3737

3838
new StrictExpectations() {{
39+
cache.getRenamedRef(ref);
40+
times = 1;
41+
result = null;
42+
3943
cache.loadRef(ref, refFormat, Model.class);
4044
times = 1;
4145
result = mockedModel;

modules/swagger-parser/src/test/resources/nested-references/b.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ definitions:
1111
$ref: "./a.yaml#/definitions/j"
1212
k:
1313
type: object
14+
title: k-definition
1415
properties:
1516
name:
1617
type: string

0 commit comments

Comments
 (0)